Re: [RFA_v4 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND'

Pedro Alves
2018-07-11T10:58:57Z

On 07/10/2018 10:39 PM, Philippe Waroquiers wrote:
> This is the fifth iteration of the patch series that:
> * implements a new command
> 'frame apply [all | COUNT | -COUNT | level LEVEL...] [FLAG]... COMMAND'.
> * enhance 'thread apply COMMAND' by adding FLAG arguments.
> * adds some shortcuts commands.
> * documents the above in gdb.texinfo and NEWS.
> * adds a unit test for cli-utils.c.
> * adds test for 'frame apply'.
> * modify gdb.threads/pthreads.exp to test 'thread apply' FLAG arguments.
>
> The fifth version is RFA v4. It handles the third set of comments
> given by Pedro.
> The main changes compared to RFA v3 are:
> * frame level LEVEL... replaces frame id ID...

Very nice.

The changes to the testcases and the unit tests makes
them much clearer, IMHO, well done.

This version looks great to me.

Thanks,
Pedro Alves