Re: [RFC] mi: add -a option to the "-data-disassemble" command

Eli Zaretskii
2018-07-06T12:37:26Z

> From: Jan Vrany <jan.vrany@fit.cvut.cz>
> Cc: Jan Vrany <jan.vrany@fit.cvut.cz>
> Date: Fri, 6 Jul 2018 10:39:25 +0100
>
> A CLI command "disassemble" allows use to specify a single
> address - in that case function surrounding that address is
> disassembled.
>
> This commit adds this feature to MI command "-data-disassemble".

Thanks.

> @@ -30959,6 +30960,9 @@ Where:
> is the beginning address (or @code{$pc})
> @item @var{end-addr}
> is the end address
> +@item @var{addr}
> +is the address anywhere in function code (or function name). If @var{addr}
^^
Two spaces between sentences, please.

> +is specified, whole function surrounding that address will be disassembled.
^^^^^^^^^^^^^^
"the whole function"

Also, since ADDR could be the name of a function, I'd add here a
sentence describing that situation, since there could be no function
"surrounding" a function name.

What about NEWS?

The documentation part is approved when the above nits are fixed.