Re: [RFC] mi: add -a option to the "-data-disassemble" command

Eli Zaretskii
2018-07-14T18:27:39Z

> From: Jan Vrany <jan.vrany@fit.cvut.cz>
> Cc: Jan Vrany <jan.vrany@fit.cvut.cz>
> Date: Sat, 14 Jul 2018 18:39:31 +0100
>
> A CLI command "disassemble" allows use to specify a single
> address - in that case function surrounding that address is
> disassembled.

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 839466e7e0..3367be4375 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,9 @@
>
> *** Changes since GDB 8.1
>
> +* The '-data-disassemble' MI command now accepts an '-a' option to disassemble
> + the whole function surrounding given program counter value or function name.
> +
> * The 'symbol-file' command now accepts an '-o' option to add a relative
> offset to all sections.

This part is okay.

> +@item @var{addr}
> +is the address anywhere in function code (or function name). If @var{addr}
> +is specified, the whole function surrounding that address will be disassembled.
> +Id @var{addr} is a function name, the whole function with that name will be
^^
Typo.

Otherwise, the documentation part is approved.