Re: [RFC] mi: add -a option to the "-data-disassemble" command

Tom Tromey
2018-07-31T15:48:40Z

>>>>> "Jan" == Jan Vrany <jan.vrany@fit.cvut.cz> writes:

>> The indentation looked slightly off here.
>> It could just be how the patch looked here, but could you double-check
>> just in case?

Jan> My fault. My editor put 8 spaces instead of tab (\t) at the beginning of
Jan> my lines. Will fix.

Thanks. According to .dir-locals.el, tabs are fine, assuming things
line up properly. (But there's been talk over the years of switching
purely to spaces, and IIRC using only spaces is also fine.)

Jan> I'm sorry I'm confused. Let me try to explain. There are (now) four forms:

Jan> 1a) -f filename -l linenum
Jan> 1b) -f filename -l linenum -n lines
Jan> 2) -s start-addr -e end-addr
Jan> 3) -a addr

Jan> Command must have one of the above four forms, otherwise it's invalid. Each
Jan> "line" in the code above checks one of the above form (in order as written here).
Jan> Note, that there's negation at the very beginning, so the condition holds
Jan> if the command has none of the four forms. Seems "good" to me. Makes sense?

Yes, thanks for explaining this. I was misreading the new code here.

Jan> Now, it appears to me that first two lines can be merged as forms 1a and 1b differ only
Jan> in presence of lines. Also, I forgot to update the comment above. So, what about:
[...]

Thank you, that seems like a good improvement.

Tom