From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCH] gdb/testsuite: Run test when software watchpoints are used
Date: Wed, 04 Jul 2018 16:40:00 -0000 [thread overview]
Message-ID: <20180704164017.5849-1-andrew.burgess@embecosm.com> (raw)
The test gdb.base/watchpoint-reuse-slot.exp can be run when software
watchpoints are in use, we just need to update one test pattern to
look for 'Watchpoint' instead of 'Hardware watchpoint' in one case.
gdb/testsuite/ChangeLog:
* gdb.base/watchpoint-reuse-slot.exp: Test can be run using
software watchpoints, we just need to update a test pattern in one
place.
---
gdb/testsuite/ChangeLog | 6 ++++++
gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp | 14 ++++++++------
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp b/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp
index f196b89eab..445c350ef2 100644
--- a/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp
+++ b/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp
@@ -22,11 +22,6 @@
# operation. (Note that we don't have any of these watchpoints
# trigger.)
-if [target_info exists gdb,no_hardware_watchpoints] {
- unsupported "no target support"
- return
-}
-
standard_testfile
if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
@@ -193,8 +188,15 @@ proc watch_command {cmd base offset width} {
gdb_test "hbreak $expr" "Hardware assisted breakpoint \[0-9\]+ at $hex"
} elseif {$cmd == "watch"} {
set expr "*(buf.byte + $base + $offset)@$width"
+
+ if [target_info exists gdb,no_hardware_watchpoints] {
+ set wp_prefix "Watchpoint"
+ } else {
+ set wp_prefix "Hardware watchpoint"
+ }
+
gdb_test "$cmd $expr" \
- "Hardware watchpoint \[0-9\]+: [string_to_regexp $expr]"
+ "${wp_prefix} \[0-9\]+: [string_to_regexp $expr]"
} elseif {$cmd == "awatch"} {
set expr "*(buf.byte + $base + $offset)@$width"
gdb_test "$cmd $expr" \
--
2.14.4
next reply other threads:[~2018-07-04 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 16:40 Andrew Burgess [this message]
2018-07-06 2:53 ` Simon Marchi
2018-07-06 13:59 ` Andrew Burgess
2018-07-06 14:43 ` Simon Marchi
2018-07-06 23:21 ` Andrew Burgess
2018-07-07 0:47 ` Simon Marchi
2018-07-10 14:01 ` Andrew Burgess
2018-10-31 13:52 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704164017.5849-1-andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox