From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19750 invoked by alias); 28 Jun 2018 17:31:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19191 invoked by uid 89); 28 Jun 2018 17:30:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=you! X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Jun 2018 17:30:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B4270116416; Thu, 28 Jun 2018 13:30:04 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id VBmMHfL7VsUq; Thu, 28 Jun 2018 13:30:04 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7FDF51163C3; Thu, 28 Jun 2018 13:30:04 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A3AA18793F; Thu, 28 Jun 2018 10:30:02 -0700 (PDT) Date: Thu, 28 Jun 2018 17:31:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Add --enable-codesign to gdb's configure Message-ID: <20180628173002.GA2511@adacore.com> References: <20180628163745.12716-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180628163745.12716-1-tom@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-06/txt/msg00694.txt.bz2 Hi Tom, On Thu, Jun 28, 2018 at 10:37:45AM -0600, Tom Tromey wrote: > macOS requires that the gdb executable be signed in order to be able > to successfully use ptrace. This must be done after each link. > > This patch adds a new --enable-codesign configure option so that this > step can be automated. > > gdb/ChangeLog > 2018-06-28 Tom Tromey > > * NEWS: Mention --enable-codesign. > * silent-rules.mk (ECHO_SIGN): New variable. > * configure.ac: Add --enable-codesign. > * configure: Rebuild. > * Makefile.in (CODESIGN, CODESIGN_CERT): New variables. > (gdb$(EXEEXT)): Optionally invoke codesign. Good idea! The NEWS portion needs to wait for Eli's feedback. But the rest looks good to me (the NEWS entry too, FWIW). Thank you! -- Joel