Re: [PATCH 4/4] Variable size for regs mask in collection list

Pedro Alves
2018-06-26T16:58:47Z

Hi,

I quickly skimmed this one and noticed a couple formatting nits,
mentioned below.

On 06/20/2018 10:08 PM, Pedro Franco de Carvalho wrote:

> @@ -1086,9 +1087,21 @@ collection_list::add_static_trace_data ()
> }
>
> collection_list::collection_list ()
> - : m_regs_mask (),
> - m_strace_data (false)
> + : m_strace_data (false)
> {
> + /* Guess the number of bytes needed for the register mask. If it's
> + too low, it will be expanded in add_register. If it's too high,
> + stringify will ignore the extra bytes.

Double-space after the periods of the first two sentences.

> +
> + The mask shouldn't include pseudoreg numbers, but
> + encode_actions_1 currently doesn't handle remote register numbers
> + and pseudoregs properly for tracepoint actions that don't
> + generate an AX (e.g. "collect $<pseudoreg>"). */
> + int num_regs = gdbarch_num_regs (target_gdbarch ())
> + + gdbarch_num_pseudo_regs (target_gdbarch ());

Wrap in parens so that emacs tab-indents the second line
under gdbarch:

int num_regs = (gdbarch_num_regs (target_gdbarch ())
+ gdbarch_num_pseudo_regs (target_gdbarch ()));

Thanks,
Pedro Alves