Re: [PATCH][gdb/testsuite/ada] Fix number-of-bp test in bp_inlined_func.exp

Joel Brobecker
2018-06-18T15:31:35Z

> > - Can you also include the platform itself on which you did the
> > testing?
> >
>
> Done.
>
> > - One spelling issue -- see below.
> >
>
> Fixed.
>
> Thanks for the review.

You are welcome.

In scanning quickly the commit, I noticed you said "x86_64" as
the platform. No need to change anything now, but for your next
submissions, it's better to include the OS as well. Typically,
you'll see people say "tested on x86_64-linux" or "x86-windows",
or "ppc-elf". Many times, the OS doesn't matter, but it's always
good to have it, because the behavior does often depend on the OS.

Thanks for the patch, though. GDB is the better for it, and this is
what _really_ matters ;-).

--
Joel