From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122490 invoked by alias); 18 Jun 2018 00:12:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122472 invoked by uid 89); 18 Jun 2018 00:12:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=spelling, Atm, spell X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Jun 2018 00:12:00 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E6C445628C; Sun, 17 Jun 2018 20:11:58 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id KUB6cBJ6Acku; Sun, 17 Jun 2018 20:11:58 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B6FBA56286; Sun, 17 Jun 2018 20:11:58 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3A4A684350; Sun, 17 Jun 2018 20:11:58 -0400 (EDT) Date: Mon, 18 Jun 2018 00:12:00 -0000 From: Joel Brobecker To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/testsuite/ada] Fix number-of-bp test in bp_inlined_func.exp Message-ID: <20180618001158.GA2447@adacore.com> References: <20180617155221.kqev7e3bwxb5uxmq@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180617155221.kqev7e3bwxb5uxmq@localhost.localdomain> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-06/txt/msg00432.txt.bz2 Hello, > Atm bp_inlined_func.exp passes for a combined current gcc and gdb-binutils > repos build but fails for a build with system gcc (7.3.1) and ld (2.29.1). > > It checks for 4 breakpoints on read_small: > ... > gdb_test "break read_small" \ > "Breakpoint $decimal at $hex: read_small\\. \\(4 locations\\)" \ > "set breakpoint at read_small" > ... > and fails because it gets 5 breakpoint locations instead: > ... > (gdb) break read_small > Breakpoint 2 at 0x401f9a: read_small. (5 locations) > (gdb) FAIL: gdb.ada/bp_inlined_func.exp: set breakpoint at read_small > ... > > The 4 expected breakpoint locations are inlined versions of read_small, and > the 5th breakpoint location has this address: > ... > (gdb) info breakpoint > Num Type Disp Enb Address What > 1 breakpoint keep y > 1.1 y 0x0000000000401f9a in b.read_small > at bp_inlined_func/b.adb:20 > ... > which is the read_small function itself: > ... > (gdb) x 0x0000000000401f9a > 0x401f9a : 0x22f8058b > ... > > This patch updates the test to allow 5 breakpoint locations. > > Tested on the configurations mentioned above. > > OK for trunk? OK with me, with a few comments: - Can you include the description you provided above as part of the commit's revision log? I would avoid "Atm" and spell it out as well. This is a bit of a nitpicking, but it's an easy thing to be doing and can help readers less familiar with English. - Can you also include the platform itself on which you did the testing? - One spelling issue -- see below. > [gdb/testsuite/ada] Fix number-of-bp test in bp_inlined_func.exp > > 2018-06-17 Tom de Vries > > * gdb.ada/bp_inlined_func.exp: Allow 5 breakpoint locations. > > --- > gdb/testsuite/gdb.ada/bp_inlined_func.exp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.ada/bp_inlined_func.exp b/gdb/testsuite/gdb.ada/bp_inlined_func.exp > index 0f615f5d9b..79f9697124 100644 > --- a/gdb/testsuite/gdb.ada/bp_inlined_func.exp > +++ b/gdb/testsuite/gdb.ada/bp_inlined_func.exp > @@ -29,10 +29,10 @@ if ![runto_main] then { > } > > # Check that inserting breakpoint on read_small inlined function inserts > -# 4 breakpoints. > +# 4 breakpoints (or posibbly 5, including the read_small function itself). "posibbly" -> "possibly". > gdb_test "break read_small" \ > - "Breakpoint $decimal at $hex: read_small\\. \\(4 locations\\)" \ > + "Breakpoint $decimal at $hex: read_small\\. \\(\[45\] locations\\)" \ > "set breakpoint at read_small" > > # We do not verify each breakpoint info, but use continue commands instead Thank you, -- Joel