From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52488 invoked by alias); 31 May 2018 01:37:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52478 invoked by uid 89); 31 May 2018 01:37:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 May 2018 01:37:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5DE13117F2A; Wed, 30 May 2018 21:37:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id A0PVn1fnY2Yx; Wed, 30 May 2018 21:37:27 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2CF78117F1D; Wed, 30 May 2018 21:37:27 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 768D783056; Wed, 30 May 2018 18:37:25 -0700 (PDT) Date: Thu, 31 May 2018 06:22:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 4/4] Remove type_name_no_tag and rename type_name_no_tag_or_error Message-ID: <20180531013725.e5nbd2ykl2hn2p2v@adacore.com> References: <20180417195125.14200-1-tom@tromey.com> <20180417195125.14200-5-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180417195125.14200-5-tom@tromey.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-05/txt/msg00834.txt.bz2 > type_name_no_tag is just a plain wrapper for TYPE_NAME now, so this > patch removes it. And, because tag names no longer exist, this > renames type_name_no_tag_or_error to type_name_or_error. > > ChangeLog > 2018-04-17 Tom Tromey > > * valops.c (value_cast_structs, destructor_name_p): Update. > * symtab.c (gdb_mangle_name): Update. > * stabsread.c (define_symbol, read_cpp_abbrev, read_baseclasses): > Update. > * p-valprint.c (pascal_object_is_vtbl_ptr_type) > (pascal_object_print_value_fields, pascal_object_print_value): > Update. > * p-typeprint.c (pascal_type_print_derivation_info): Update. > * linespec.c (find_methods): Update. > * gdbtypes.h (type_name_no_tag): Remove. > (type_name_or_error): Rename from type_name_no_tag_or_error. > * gdbtypes.c (type_name_no_tag): Remove. > (type_name_or_error): Rename from type_name_no_tag_or_error. > (lookup_struct_elt_type, check_typedef): Update. > * expprint.c (print_subexp_standard): Update. > * dwarf2read.c (dwarf2_add_field, load_partial_dies): Update. > * d-namespace.c (d_lookup_nested_symbol): Update. > * cp-valprint.c (cp_is_vtbl_ptr_type, cp_print_value_fields) > (cp_print_class_member): Update. > * cp-namespace.c (cp_lookup_nested_symbol): Update. > * completer.c (add_struct_fields): Update. > * c-typeprint.c (cp_type_print_derivation_info) > (c_type_print_varspec_prefix, c_type_print_base_struct_union): > Update. > * ada-lang.c (parse_old_style_renaming, xget_renaming_scope) > (ada_prefer_type, ada_is_exception_sym): Update. Looks good, Tom! (approved) -- Joel