From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65196 invoked by alias); 31 May 2018 01:05:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65178 invoked by uid 89); 31 May 2018 01:05:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 May 2018 01:05:34 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E2040560BA; Wed, 30 May 2018 21:05:32 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 0UyPNTy3ky6a; Wed, 30 May 2018 21:05:32 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A1C86560B9; Wed, 30 May 2018 21:05:32 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id DA10683056; Wed, 30 May 2018 18:05:30 -0700 (PDT) Date: Thu, 31 May 2018 01:33:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/4] Make c_type_print_varspec_suffix static Message-ID: <20180531010530.lr4q7svse5kmjouh@adacore.com> References: <20180417195125.14200-1-tom@tromey.com> <20180417195125.14200-2-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180417195125.14200-2-tom@tromey.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-05/txt/msg00831.txt.bz2 Hi Tom, On Tue, Apr 17, 2018 at 01:51:22PM -0600, Tom Tromey wrote: > I noticed that c_type_print_varspec_suffix is only called from > c-typeprint.c, so this patch makes it "static". > > ChangeLog > 2018-04-17 Tom Tromey > > * typeprint.h (c_type_print_varspec_suffix): Don't declare. > * c-typeprint.c (c_type_print_varspec_suffix): Now static. So very sorry again for how long it's taking to review your patches. This one is fairly clearly an improvement on its own, so approved. -- Joel