Re: [PATCH] Process record: Fix null deref when loading empty core file

[Joel Brobecker <brobecker@adacore.com>]

Hi Andrew,

The patch you sent seems reasonable to me, and I'd be ready to
approve it. But the information you sent below is extremely useful
for understanding the conditions necessary to reproduce the issue
you are fixing. This is both useful for understanding and reviewing
your patch, but also for others who might either find this thread,
or else be looking at your patch, and wondering what you were trying
to do, when you made your change.

With that in mind, can you create a commit which contains the
explanation you just gave in the revision log, followed by whatever
explanation you feel is necessary to provide as to how you fixed
the problem, followed by the ChangeLog entry and a note of how
the fix was tested (which platform, which tests that were a FAIL
now became a PASS).

Browsing the gdb-patches mailing-list for example of how others
submit patches should give you a fair idea of what we prefer.

Do not hesitate to Cc: me on the resubmission of this specific patch,
and I will make every effort to review promptly.

Thank you!

On Fri, May 11, 2018 at 05:00:29PM -0500, Andrew D'Addesio wrote:

> Here's an explanation of the bug:
> 
> Description:
[snip]

-- 
Joel