From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114069 invoked by alias); 23 May 2018 04:59:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113432 invoked by uid 89); 23 May 2018 04:59:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 May 2018 04:59:04 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 9F08429E982 for ; Tue, 22 May 2018 23:59:02 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id LLrafwLUZBcCXLLrafqn8R; Tue, 22 May 2018 23:59:02 -0500 X-Authority-Reason: nr=8 Received: from 174-29-44-154.hlrn.qwest.net ([174.29.44.154]:56108 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fLLra-003S5D-Du; Tue, 22 May 2018 23:59:02 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 13/42] Remove buildsym_new_init Date: Wed, 23 May 2018 04:59:00 -0000 Message-Id: <20180523045851.11660-14-tom@tromey.com> In-Reply-To: <20180523045851.11660-1-tom@tromey.com> References: <20180523045851.11660-1-tom@tromey.com> X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fLLra-003S5D-Du X-Source-Sender: 174-29-44-154.hlrn.qwest.net (bapiya.Home) [174.29.44.154]:56108 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00598.txt.bz2 buildsym_new_init is just an alias for buildsym_init. This removes it. In the long run buildsym_init will also go away; this patch just helps make things a bit clearer in the meantime. gdb/ChangeLog 2018-05-22 Tom Tromey * xcoffread.c (xcoff_new_init): Update. * mipsread.c (mipscoff_new_init): Update. * mdebugread.c (mdebug_build_psymtabs): Update. * elfread.c (elf_new_init): Update. * dbxread.c (dbx_new_init, coffstab_build_psymtabs) (elfstab_build_psymtabs, stabsect_build_psymtabs): Update. * buildsym.h (buildsym_new_init): Don't declare. * buildsym.c (buildsym_new_init): Remove. --- gdb/ChangeLog | 11 +++++++++++ gdb/buildsym.c | 12 +----------- gdb/buildsym.h | 4 +--- gdb/dbxread.c | 8 ++++---- gdb/elfread.c | 2 +- gdb/mdebugread.c | 2 +- gdb/mipsread.c | 2 +- gdb/xcoffread.c | 2 +- 8 files changed, 21 insertions(+), 22 deletions(-) diff --git a/gdb/buildsym.c b/gdb/buildsym.c index 10c816efb3..6fe413be8a 100644 --- a/gdb/buildsym.c +++ b/gdb/buildsym.c @@ -1759,7 +1759,7 @@ get_last_source_start_addr () corresponding to a psymtab. */ void -buildsym_init (void) +buildsym_init () { subfile_stack = NULL; @@ -1783,13 +1783,3 @@ buildsym_init (void) gdb_assert (pending_addrmap == NULL); gdb_assert (buildsym_compunit == NULL); } - -/* Initialize anything that needs initializing when a completely new - symbol file is specified (not just adding some symbols from another - file, e.g. a shared library). */ - -void -buildsym_new_init (void) -{ - buildsym_init (); -} diff --git a/gdb/buildsym.h b/gdb/buildsym.h index a6bed3c611..77fc5bdd3c 100644 --- a/gdb/buildsym.h +++ b/gdb/buildsym.h @@ -209,9 +209,7 @@ extern void augment_type_symtab (void); extern void scan_file_globals (struct objfile *objfile); -extern void buildsym_new_init (void); - -extern void buildsym_init (void); +extern void buildsym_init (); extern struct context_stack *push_context (int desc, CORE_ADDR valu); diff --git a/gdb/dbxread.c b/gdb/dbxread.c index eed4a28b90..52241f620d 100644 --- a/gdb/dbxread.c +++ b/gdb/dbxread.c @@ -569,7 +569,7 @@ static void dbx_new_init (struct objfile *ignore) { stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); init_header_files (); } @@ -3104,7 +3104,7 @@ coffstab_build_psymtabs (struct objfile *objfile, perror_with_name (name); stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); free_header_files (); init_header_files (); @@ -3193,7 +3193,7 @@ elfstab_build_psymtabs (struct objfile *objfile, asection *stabsect, perror_with_name (name); stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); free_header_files (); init_header_files (); @@ -3293,7 +3293,7 @@ stabsect_build_psymtabs (struct objfile *objfile, char *stab_name, perror_with_name (name); stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); free_header_files (); init_header_files (); diff --git a/gdb/elfread.c b/gdb/elfread.c index b4b4a1b24c..8978f15e88 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -1325,7 +1325,7 @@ static void elf_new_init (struct objfile *ignore) { stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); } /* Perform any local cleanups required when we are done with a particular diff --git a/gdb/mdebugread.c b/gdb/mdebugread.c index 3f0cdc74aa..e56e009589 100644 --- a/gdb/mdebugread.c +++ b/gdb/mdebugread.c @@ -345,7 +345,7 @@ mdebug_build_psymtabs (minimal_symbol_reader &reader, debug_info = info; stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); free_header_files (); init_header_files (); diff --git a/gdb/mipsread.c b/gdb/mipsread.c index 7b6ec2e48d..3bdc50733d 100644 --- a/gdb/mipsread.c +++ b/gdb/mipsread.c @@ -54,7 +54,7 @@ static void mipscoff_new_init (struct objfile *ignore) { stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); } /* Initialize to read a symbol file (nothing to do). */ diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c index 8bb244618c..e9bb79c87a 100644 --- a/gdb/xcoffread.c +++ b/gdb/xcoffread.c @@ -1925,7 +1925,7 @@ static void xcoff_new_init (struct objfile *objfile) { stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); } /* Do initialization in preparation for reading symbols from OBJFILE. -- 2.13.6