From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12639 invoked by alias); 22 May 2018 12:48:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91462 invoked by uid 89); 22 May 2018 12:43:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 May 2018 12:43:00 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4MCdQiJ013270 for ; Tue, 22 May 2018 08:42:59 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j4g5890va-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 22 May 2018 08:42:59 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 May 2018 13:42:57 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 22 May 2018 13:42:55 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4MCgtvg7209220; Tue, 22 May 2018 12:42:55 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 62DC4AE053; Tue, 22 May 2018 13:32:09 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 512C8AE04D; Tue, 22 May 2018 13:32:09 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.77]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 22 May 2018 13:32:09 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 041F6D804DB; Tue, 22 May 2018 14:42:55 +0200 (CEST) Subject: Re: [PATCH v2 2/8] [PowerPC] Consolidate wordsize getter between native and gdbserver To: pedromfc@linux.vnet.ibm.com (Pedro Franco de Carvalho) Date: Tue, 22 May 2018 12:56:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20180521204458.19070-2-pedromfc@linux.vnet.ibm.com> from "Pedro Franco de Carvalho" at May 21, 2018 05:44:52 PM MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 18052212-0040-0000-0000-0000043C85D9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18052212-0041-0000-0000-00002641B8F6 Message-Id: <20180522124255.041F6D804DB@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-22_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805220148 X-SW-Source: 2018-05/txt/msg00546.txt.bz2 Pedro Franco de Carvalho wrote: > gdb/ChangeLog: > yyyy-mm-dd Pedro Franco de Carvalho > > * configure.nat : Add ppc-linux.o to NATDEPFILES. > * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to > nat/ppc-linux.c. > (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call > ppc_linux_target_wordsize with tid. > (ppc_linux_nat_target::read_description): Call ppc_linux_target > wordsize with tid. > * nat/ppc-linux.c: Include nat/gdb_ptrace.h. > (ppc64_64bit_inferior_p): Add static and inline specifiers. > (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add > tid parameter. Remove static specifier. > * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration. > (ppc_linux_target_wordsize): New declaration. > > gdb/gdbserver/ChangeLog: > yyyy-mm-dd Pedro Franco de Carvalho > > * linux-ppc-low.c (ppc_arch_setup): Remove code for getting the > wordsize of the inferior. Call ppc_linux_target_wordsize. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com