Re: [PATCH v2 0/3] Poison obstack functions

Simon Marchi
2018-05-21T01:11:00Z

On 2018-04-27 11:31 PM, Simon Marchi wrote:
> v2 of https://sourceware.org/ml/gdb-patches/2018-04/msg00524.html
>
> What's new:
>
> - Don't allocate mapped_index on an obstack (patch 1/3)
> - Use OBSTACK_ZALLOC instead of XOBNEW + memset when possible (patch
> 3/3)
>
> Simon Marchi (3):
> Don't allocate mapped_index on the objfile obstack
> Introduce obstack_new, poison other "typed" obstack functions
> Use XOBNEW/XOBNEWVEC/OBSTACK_ZALLOC when possible
>
> gdb/ada-lang.c | 3 +--
> gdb/common/poison.h | 31 +++++++++++++++++++++++-
> gdb/common/traits.h | 8 ++++++
> gdb/dwarf2-frame.c | 3 +--
> gdb/dwarf2read.c | 14 +++--------
> gdb/dwarf2read.h | 2 +-
> gdb/gdb_obstack.h | 36 ++++++++++++++++++++++++---
> gdb/gdbarch.c | 9 ++-----
> gdb/gdbarch.h | 10 +++++---
> gdb/gdbarch.sh | 21 ++++++++--------
> gdb/hppa-tdep.c | 7 ++----
> gdb/mdebugread.c | 51 +++++++++++++--------------------------
> gdb/minsyms.c | 6 ++---
> gdb/objfiles.c | 9 ++-----
> gdb/psymtab.c | 4 +--
> gdb/stabsread.c | 7 ++----
> gdb/target-descriptions.c | 7 +-----
> gdb/xcoffread.c | 3 +--
> 18 files changed, 125 insertions(+), 106 deletions(-)
>

Since Tom is playing with some things that are obstack allocated in dwarf2read, I
finally pushed this in case it helps.

Simon