Hi Simon, > >> gdb/unittests/format_pieces-selftests.c:51: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value > > gdb/unittests/format_pieces-selftests.c:51: check ("Hello %d%llx%%d", > >> gdb/unittests/format_pieces-selftests.c:56: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value > > gdb/unittests/format_pieces-selftests.c:56: format_piece ("%llx", long_long_arg), > > > > These are false positives. You can tag them as OK with a /* ARI: ... */ comment. But I suspect we just want to exclude files in gdb/unittests instead? Here is a patch that does that. Tested by checking the change in output before and after: 1101,1120d1100 < ./unittests/array-view-selftests.c < ./unittests/common-utils-selftests.c < ./unittests/environ-selftests.c < ./unittests/function-view-selftests.c < ./unittests/lookup_name_info-selftests.c < ./unittests/memory-map-selftests.c < ./unittests/memrange-selftests.c < ./unittests/observable-selftests.c < ./unittests/offset-type-selftests.c < ./unittests/optional-selftests.c < ./unittests/ptid-selftests.c < ./unittests/rsp-low-selftests.c < ./unittests/scoped_fd-selftests.c < ./unittests/scoped_mmap-selftests.c < ./unittests/scoped_restore-selftests.c < ./unittests/string_view-selftests.c < ./unittests/tracepoint-selftests.c < ./unittests/unpack-selftests.c < ./unittests/utils-selftests.c < ./unittests/xml-utils-selftests.c gdb/ChangeLog: * contrib/ari/gdb_find.sh: Exclude the unittest directory. -- Joel