From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1451 invoked by alias); 18 May 2018 10:42:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 968 invoked by uid 89); 18 May 2018 10:42:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:PTRACE_, sk:ptrace_, sk:regcach, H*x:version X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 10:42:16 +0000 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4IAd8kC050633 for ; Fri, 18 May 2018 06:42:14 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j1tr0y4da-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 18 May 2018 06:42:14 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 18 May 2018 11:42:12 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 18 May 2018 11:42:09 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4IAg9Zd4194652; Fri, 18 May 2018 10:42:09 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 044E75204B; Fri, 18 May 2018 10:32:15 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.164.161.176]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id E591052043; Fri, 18 May 2018 10:32:14 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id E9E0BD80322; Fri, 18 May 2018 12:42:08 +0200 (CEST) Subject: Re: [PATCH 5/8] [PowerPC] Fix access to VSCR in linux targets To: pedromfc@linux.vnet.ibm.com (Pedro Franco de Carvalho) Date: Fri, 18 May 2018 15:37:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <878t8if277.fsf@linux.vnet.ibm.com> from "Pedro Franco de Carvalho" at May 17, 2018 05:37:48 PM MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 18051810-0044-0000-0000-00000553DBA4 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18051810-0045-0000-0000-000028955609 Message-Id: <20180518104208.E9E0BD80322@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-18_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805180118 X-SW-Source: 2018-05/txt/msg00402.txt.bz2 Pedro Franco de Carvalho wrote: > Ulrich Weigand writes: > > > I'm wondering if we shouldn't have the common regcache_collect_regset > > routine zero out areas covered by REGCACHE_MAP_SKIP? Then we wouldn't > > need this extra routine here. > > I think this might affect the s390 target: in s390-linux-nat, > fill_gregset uses collect_regset on a buffer that has already been > filled through ptrace (PTRACE_PEEKUSR_AREA), which is then used to > extract pswm, so it relies on collect_regset not changing the buffer on > the skipped slots. Ah, I see. Good catch! I think your original approach is OK, then. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com