Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: time to release soon? GDB 8.1.1 release 2018-05-14 update
Date: Thu, 17 May 2018 20:37:00 -0000	[thread overview]
Message-ID: <20180517172317.rtfaa3aoluse3gtd@adacore.com> (raw)
In-Reply-To: <87in7mgvh2.fsf@tromey.com>

> >>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
> 
> Joel>        This is a regression. Tom sent a patch which got peer-reviewed
> Joel>        by KeithS, and I gave it a nod, so it should go in sometime
> Joel>        soon. But we still need to discuss whether the patch is suitable
> Joel>        for 8.1.1.
> 
> Joel>        https://sourceware.org/ml/gdb-patches/2018-04/msg00234.html
> 
> Sorry, I didn't realize that the patch was approved.

Probably because I wasn't clear.

> Jan had also reported a crash with Rust and -readnow.
> That requires the above patch, but also either:
> 
> https://sourceware.org/ml/gdb-patches/2018-04/msg00237.html
> 
> or
> 
> https://sourceware.org/ml/gdb-patches/2018-04/msg00353.html
> 
> ... with the latter being preferred, though perhaps a bit invasive for a
> backport.

Agreed that the second patch is a little invasive. Looking at the first
one, it seems very localized, and can only affect Rust. If you feel
confident that the patch is safe, we could just create a PR number
for this issue, add it to the ChangeLog and revision log, and then
use version #1 for the 8.1 branch.

I started reviewing the tag-name-removal patch series, but ran out
of time. And now, it is looking like it's going to be a couple of weeks
before I can look at it again... Sorry!

-- 
Joel


  reply	other threads:[~2018-05-17 17:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14 17:59 Joel Brobecker
2018-05-17 16:19 ` Tom Tromey
2018-05-17 20:37   ` Joel Brobecker [this message]
2018-05-18  0:32     ` Tom Tromey
2018-05-18 19:14       ` Joel Brobecker
2018-05-18 19:50         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180517172317.rtfaa3aoluse3gtd@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox