From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103919 invoked by alias); 17 May 2018 08:18:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24468 invoked by uid 89); 17 May 2018 08:15:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=buys X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 May 2018 08:15:40 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4H8ER54112983 for ; Thu, 17 May 2018 04:15:39 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 2j14bbms3y-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 17 May 2018 04:15:38 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 May 2018 09:15:36 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 17 May 2018 09:15:34 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4H8FYwZ66519050; Thu, 17 May 2018 08:15:34 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 356C14C04E; Thu, 17 May 2018 09:07:23 +0100 (BST) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 29C984C044; Thu, 17 May 2018 09:07:23 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.164.171.22]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 17 May 2018 09:07:23 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id A7888D802CA; Thu, 17 May 2018 10:15:33 +0200 (CEST) Subject: Re: [PATCH 1/8] [PowerPC] Consolidate linux target description selection To: pedromfc@linux.vnet.ibm.com (Pedro Franco de Carvalho) Date: Thu, 17 May 2018 08:28:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <87wow3uynr.fsf@linux.vnet.ibm.com> from "Pedro Franco de Carvalho" at May 16, 2018 05:35:20 PM MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 18051708-0008-0000-0000-000004F767CB X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18051708-0009-0000-0000-00001E8BDB2A Message-Id: <20180517081533.A7888D802CA@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-17_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805170077 X-SW-Source: 2018-05/txt/msg00371.txt.bz2 Pedro Franco de Carvalho wrote. > Ulrich Weigand writes: > > >> +/* Base value for ppc_linux_features variables. */ > >> +const struct ppc_linux_features ppc_linux_no_features = { > >> + 4, > >> + false, > >> + false, > >> + false, > >> + false, > >> +}; > > > > I'm not sure it makes much sense to declare "4" the default wordsize > > -- there's not really a default between 4 and 8. Maybe it would be > > clearer to just force all users to explicitly set the wordsize. > > Is something like this a good style, or should I just initialize > wordsize to 0 and let the previous assert in ppc_match_description > ensure that the wordsize is either 4 or 8? If the members are all public anyway, I'm not sure it buys us much to set wordsize in the constructor ... I'd just let the user set it and then verify via an assert, as you suggest. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com