From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8740 invoked by alias); 16 May 2018 15:53:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8715 invoked by uid 89); 16 May 2018 15:53:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 May 2018 15:53:22 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4GFncgh117680 for ; Wed, 16 May 2018 11:53:20 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j0qg98h8c-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 16 May 2018 11:53:20 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 May 2018 16:53:18 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 16 May 2018 16:53:15 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4GFrEXC8192460 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 16 May 2018 15:53:14 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AF69611C066; Wed, 16 May 2018 16:44:29 +0100 (BST) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9CCF211C05C; Wed, 16 May 2018 16:44:29 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.77]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 16 May 2018 16:44:29 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 0D4B2D802CA; Wed, 16 May 2018 17:53:14 +0200 (CEST) Subject: Re: [PATCH 3/8] [PowerPC] Disable regsets using zero sizes in gdbserver To: pedromfc@linux.vnet.ibm.com (Pedro Franco de Carvalho) Date: Wed, 16 May 2018 16:17:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20180510195840.17734-4-pedromfc@linux.vnet.ibm.com> from "Pedro Franco de Carvalho" at May 10, 2018 04:58:35 PM MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 18051615-0040-0000-0000-0000043A7861 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18051615-0041-0000-0000-0000263F90F2 Message-Id: <20180516155314.0D4B2D802CA@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-16_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805160159 X-SW-Source: 2018-05/txt/msg00352.txt.bz2 Pedro Franco de Carvalho wrote: > gdb/gdbserver/ChangeLog: > yyyy-mm-dd Pedro Franco de Carvalho > > * linux-ppc-low.c (ppc_fill_vsxregset): Remove ppc_hwcap check. > (ppc_store_vsxregset): Likewise. > (ppc_fill_vrregset): Likewise. > (ppc_store_vrregset): Likewise. > (ppc_fill_evrregset): Likewise. > (ppc_store_evrregset): Likewise. > (ppc_regsets): Set VSX/VR/EVR regset sizes to 0. > (ppc_arch_setup): Iterate through ppc_regsets and set sizes when > needed. > + for (regset = ppc_regsets; regset->size >= 0; regset++) > + switch (regset->get_request) > + { > + case PTRACE_GETVRREGS: > + regset->size = features.altivec ? SIZEOF_VRREGS : 0; > + break; > + case PTRACE_GETVSXREGS: > + regset->size = features.vsx ? SIZEOF_VSXREGS : 0; > + break; > + case PTRACE_GETEVRREGS: > + if (ppc_hwcap & PPC_FEATURE_HAS_SPE) > + regset->size = 32 * 4 + 8 + 4; This should also zero out the size if the feature is not available, just like the other cases. Otherwise, this is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com