From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5375 invoked by alias); 16 May 2018 15:50:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5365 invoked by uid 89); 16 May 2018 15:50:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1717 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 May 2018 15:50:38 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4GFnaM5117541 for ; Wed, 16 May 2018 11:50:37 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j0qg98ddg-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 16 May 2018 11:50:36 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 May 2018 16:50:34 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 16 May 2018 16:50:32 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4GFoVVE2687296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 16 May 2018 15:50:31 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 298FFAE053; Wed, 16 May 2018 16:39:51 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1834AAE05F; Wed, 16 May 2018 16:39:51 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.77]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 16 May 2018 16:39:51 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 9DA61D802CA; Wed, 16 May 2018 17:50:30 +0200 (CEST) Subject: Re: [PATCH 8/8] [PowerPC] Recognize isa205 in linux core files To: pedromfc@linux.vnet.ibm.com (Pedro Franco de Carvalho) Date: Wed, 16 May 2018 15:53:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20180510195840.17734-9-pedromfc@linux.vnet.ibm.com> from "Pedro Franco de Carvalho" at May 10, 2018 04:58:40 PM MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 18051615-0040-0000-0000-0000045A1A21 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18051615-0041-0000-0000-000020FE4D04 Message-Id: <20180516155030.9DA61D802CA@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-16_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805160159 X-SW-Source: 2018-05/txt/msg00350.txt.bz2 Pedro Franco de Carvalho wrote: > gdb/ChangeLog: > yyyy-mm-dd Pedro Franco de Carvalho > > * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the > parameter type to CORE_ADDR. > * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the > parameter type in declaration to CORE_ADDR. > * ppc-linux-tdep.c (ppc_linux_core_read_description): Call > target_auxv_search to get AT_HWCAP and use the result to get the > target description. > * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type to > CORE_ADDR. Remove the cast of the return value to unsigned > long. Check if target_auxv_search returns a value greater than > zero instead of non-zero. > (ppc_linux_nat_target::read_description): Change the type of the > hwcap variable to CORE_ADDR. > > gdb/testsuite/ChangeLog: > yyyy-mm-dd Pedro Franco de Carvalho > > * gdb.arch/powerpc-fpscr-gcore.exp: New file. > /* Fetch the AT_HWCAP entry from the aux vector. */ > -static unsigned long > +static CORE_ADDR > ppc_linux_get_hwcap (void) > { > CORE_ADDR field; > > - if (target_auxv_search (target_stack, AT_HWCAP, &field)) > - return (unsigned long) field; > + if (target_auxv_search (target_stack, AT_HWCAP, &field) > 0) > + return field; > > return 0; > } Maybe this routine should now be moved to ppc-linux-tdep.c ... > + CORE_ADDR hwcap = 0; > + > + target_auxv_search (target, AT_HWCAP, &hwcap); > + > + features.isa205 = ppc_linux_has_isa205 (hwcap); ... so it can be reused here? Otherwise this looks OK to me. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com