> > gdb/gdbserver/ChangeLog:
> > 
> >         * lynx-i386-low.c (LYNXOS_178): New macro.
> >         (usr_fcontext_t) <LYNXOS_178>: Provide a definition that matches
> >         the layout on LynxOS-178.
> 
> This syntax (with < >) is usually meant to denote fields (as if you were
> referring to field LYNXOS_178 in structure usr_fcontext_t).  To denote an
> #ifdef context (which is what I understand you want to do), I usually see
> this syntax:
> 
>   [LYNXOS_178] (usr_fcontext_t): ...
> 
> For example:
> 
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/ChangeLog-2017;h=aaadf142a4641ecd3feb26bc1dfa83dcc19e713c;hb=HEAD#l13806

Grumpf. I keep getting confused over this. Of course, you are right,
and this is explained in the GCS.

> 
> >         (lynx_i386_fill_fpregset, lynx_i386_store_fpregset): Do not
> >         handle floating point registers that are not supported by
> >         LynxOS-178.
> > 
> > OK to push to master?
> 
> Otherwise, it looks good to me.

Thanks. Attached is the patch I ended up pushing to master.

gdb/gdbserver/ChangeLog:

        * lynx-i386-low.c (LYNXOS_178): New macro.
        [LYNXOS_178] (usr_fcontext_t): Provide a definition that matches
        the layout on LynxOS-178.
        (lynx_i386_fill_fpregset, lynx_i386_store_fpregset): Do not
        handle floating point registers that are not supported by
        LynxOS-178.

-- 
Joel