From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37176 invoked by alias); 10 May 2018 16:48:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19130 invoked by uid 89); 10 May 2018 16:48:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:8700c37, expedite_regs, H*f:sk:3894bcb, H*i:sk:3894bcb X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 May 2018 16:48:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D6BB2117820; Thu, 10 May 2018 12:48:23 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id VgJ2pr1nQC+O; Thu, 10 May 2018 12:48:23 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A3F5F1162AF; Thu, 10 May 2018 12:48:23 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id ECD5F8304F; Thu, 10 May 2018 09:48:21 -0700 (PDT) Date: Thu, 10 May 2018 17:04:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] gdbserver/Windows: crash during connection establishment phase Message-ID: <20180510164821.2cewdlvpzsdpduad@adacore.com> References: <1525458603-33351-1-git-send-email-brobecker@adacore.com> <1525458603-33351-4-git-send-email-brobecker@adacore.com> <8700c375-c37b-9e59-d069-d62b6043b112@redhat.com> <20180504185818.htyn2gj2xx5i5s7f@adacore.com> <03cdded5-9f4e-fc1a-366a-1be7cd8b1837@redhat.com> <20180507214700.repkytrxbswql6z2@adacore.com> <3894bcb0-d2e6-7103-86dc-add689af07b0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3894bcb0-d2e6-7103-86dc-add689af07b0@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-05/txt/msg00243.txt.bz2 gdb/ChangeLog: * regformats/regdat.sh: Adjust script, following the addition of the new expedite_regs parameter to init_target_desc. gdb/gdbserver/ChangeLog: * tdesc.h (init_target_desc) : New parameter. * tdesc.c (init_target_desc) : New parameter. Use it to set the expedite_regs field in the given tdesc. * x86-tdesc.h: New file. * linux-aarch64-tdesc.c (aarch64_linux_read_description): Adjust following the addition of the new expedite_regs parameter to init_target_desc. * linux-tic6x-low.c (tic6x_read_description): Likewise. * linux-x86-tdesc.c: #include "x86-tdesc.h". (i386_linux_read_description, amd64_linux_read_description): Adjust following the addition of the new expedite_regs parameter to init_target_desc. * lynx-i386-low.c: #include "x86-tdesc.h". (lynx_i386_arch_setup): Adjust following the addition of the new expedite_regs parameter to init_target_desc. * nto-x86-low.c: #include "x86-tdesc.h". (nto_x86_arch_setup): Adjust following the addition of the new expedite_regs parameter to init_target_desc. * win32-i386-low.c: #include "x86-tdesc.h". (i386_arch_setup): Adjust following the addition of the new > Thanks, this looks good to me. Thanks Pedro. Pushed to master and gdb-8.1-branch, under PR cli/23158. -- Joel