From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61800 invoked by alias); 9 May 2018 21:57:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61775 invoked by uid 89); 9 May 2018 21:57:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=laptop, hurry, super X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 May 2018 21:57:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E3616117064; Wed, 9 May 2018 17:57:36 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xw8AlyzGqX6U; Wed, 9 May 2018 17:57:36 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B2BF6116377; Wed, 9 May 2018 17:57:36 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E7EA38304F; Wed, 9 May 2018 14:57:34 -0700 (PDT) Date: Wed, 09 May 2018 23:09:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] gdbserver/Windows: crash during connection establishment phase Message-ID: <20180509215734.a3yajpbtsjj2johb@adacore.com> References: <1525458603-33351-1-git-send-email-brobecker@adacore.com> <1525458603-33351-4-git-send-email-brobecker@adacore.com> <8700c375-c37b-9e59-d069-d62b6043b112@redhat.com> <20180504185818.htyn2gj2xx5i5s7f@adacore.com> <03cdded5-9f4e-fc1a-366a-1be7cd8b1837@redhat.com> <20180507214700.repkytrxbswql6z2@adacore.com> <3894bcb0-d2e6-7103-86dc-add689af07b0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3894bcb0-d2e6-7103-86dc-add689af07b0@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-05/txt/msg00225.txt.bz2 > > What do you think of the following approach? The idea is to make > > sure we never forget to set the expedite_regs field when we initialize > > the tdesc. > > Thanks, this looks good to me. Thanks, Pedro. Does it mean the first two look OK to you as well, or should I wait for specific review. Given that GDBserver appears to have been broken for quite a while, I don't think we are in any kind of hurry... Unless we decide to backport to 8.1.1? > > On Windows, starting a new process with GDBserver seeems to work, > > "seeems" -> "seems" Thanks. I think I will start running ispell on my revision logs. For various reasons, I had to transition from a laptop keyboard with nice scissor switches to super nice PC keyboard, but with cherry-mx keys, so very very different. I seem to be making those kinds of mistakes... Fixed locally. -- Joel