Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
	gdb-patches@sourceware.org,	binutils@sourceware.org
Subject: Update autotools version for gdb and binutils
Date: Tue, 08 May 2018 02:30:00 -0000	[thread overview]
Message-ID: <20180508023041.GV28782@bubble.grove.modra.org> (raw)
In-Reply-To: <7bced953b160e7baa38ccbac73824d3f@polymtl.ca>

On Mon, May 07, 2018 at 10:28:08AM -0400, Simon Marchi wrote:
> On 2018-05-07 02:15, Alan Modra wrote:
> > On Fri, May 04, 2018 at 02:42:17PM -0400, Simon Marchi wrote:
> > > ChangeLog:
> > > 
> > > 	* ar-lib: New file.
> > > 
> > > gdb/ChangeLog:
> > > 
> > > 	* update-gnulib.sh (AUTOCONF_VERSION): Bump to 2.69.
> > > 	(AUTOMAKE_VERSION): Bump to 1.16.1.
> > > 	* configure.ac: Modernize usage of AM_INIT_AUTOMAKE.
> > > 	(AC_PREREQ): Bump to 2.69.
> > > 	* import/Makefile.in: Re-generate.
> > > 	* aclocal.m4: Re-generate.
> > > 	* config.in: Re-generate.
> > > 	* configure: Re-generate.
> > 
> > If this goes in you'll need two versions of autotools for gdb, the new
> > one for gdb and the old one for bfd, opcodes, and other dirs.  I'm not
> > against the patch BTW, just that it would make sense to update all of
> > binutils-gdb.
> 
> Ah, I thought that we already needed two different versions for GDB, because
> of this line in gdb/configure.ac:
> 
>   AC_PREREQ(2.59)

That's just a minimum version.

> But the real requirement is 2.64, and seems to come from config/override.m4
> (not sure how it's invoked though).

AC_INIT

>  This applies to all projects under
> binutils-gdb, but also in the gcc source repository, doesn't it?  So we
> would need to change all of binutils-gdb and gcc at the same time, in sync?

I wasn't saying you must change all of binutils-gdb, let alone gcc,
just that it would be nice.  binutils-gdb config/* is copied from gcc
but files in config can diverge.  Changing just binutils-gdb
config/override.m4 (*) seems OK to me in the short term.  If you care
to bump autoconf to 2.69 and automake to either 1.16.1 or 1.15.1 I'll
support that for binutils, ie. I'll approve patches and deal with any
followup.  (The choice between automake 1.15.1 and 1.16.1 boils down
to convenience for developers in having 1.15.1 more available in
distros versus wanting the bug fixes in 1.16.1.  I'd be inclined to go
with 1.15.1 myself.)

If other maintainers disagree, speak up now!

*) The reason binutils-gdb and gcc share a top level dir, config, and
most include files is to support combined tree builds.  I don't know
how many people try to do that nowadays, and a combined tree build
with --enable-maintainer-mode running autotools seems a little
insane to me.

-- 
Alan Modra
Australia Development Lab, IBM


  reply	other threads:[~2018-05-08  2:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 18:44 [PATCH] gdb: Update autotools version used for gnulib import Simon Marchi
2018-05-04 19:34 ` Simon Marchi
2018-05-07  6:15 ` Alan Modra
2018-05-07 14:28   ` Simon Marchi
2018-05-08  2:30     ` Alan Modra [this message]
2018-05-08 20:39       ` Update autotools version for gdb and binutils Matt Rice
2018-05-08 22:12       ` Joseph Myers
2018-05-09 15:46         ` Simon Marchi
2018-05-10 14:40           ` Alan Modra
2018-06-15  0:49             ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508023041.GV28782@bubble.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox