Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFA] Remove output_command_const
Date: Sat, 05 May 2018 15:40:00 -0000	[thread overview]
Message-ID: <20180505153947.16864-1-tom@tromey.com> (raw)

I happened to notice that output_command_const still exists, but is
not needed any more -- commands are always const-correct now.  This
patch removes this leftover.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* printcmd.c (output_command): Remove.
	(output_command_const): Rename to output_command.
	* valprint.h (output_command): Rename from output_command_const.
	* tracepoint.c (trace_dump_actions): Call output_command.
---
 gdb/ChangeLog    |  7 +++++++
 gdb/printcmd.c   | 10 +---------
 gdb/tracepoint.c |  2 +-
 gdb/valprint.h   |  2 +-
 4 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/gdb/printcmd.c b/gdb/printcmd.c
index 4696373b2c..0dfea34753 100644
--- a/gdb/printcmd.c
+++ b/gdb/printcmd.c
@@ -1221,16 +1221,8 @@ call_command (const char *exp, int from_tty)
 
 /* Implementation of the "output" command.  */
 
-static void
-output_command (const char *exp, int from_tty)
-{
-  output_command_const (exp, from_tty);
-}
-
-/* Like output_command, but takes a const string as argument.  */
-
 void
-output_command_const (const char *exp, int from_tty)
+output_command (const char *exp, int from_tty)
 {
   char format = 0;
   struct value *val;
diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c
index e170d704bc..7636fdb023 100644
--- a/gdb/tracepoint.c
+++ b/gdb/tracepoint.c
@@ -2723,7 +2723,7 @@ trace_dump_actions (struct command_line *action,
 			}
 
 		      printf_filtered ("%s = ", cmd);
-		      output_command_const (cmd, from_tty);
+		      output_command (cmd, from_tty);
 		      printf_filtered ("\n");
 		    }
 		  action_exp = next_comma;
diff --git a/gdb/valprint.h b/gdb/valprint.h
index f005c31f87..1f62039be5 100644
--- a/gdb/valprint.h
+++ b/gdb/valprint.h
@@ -210,7 +210,7 @@ extern void generic_printstr (struct ui_file *stream, struct type *type,
    arguments passed to all command implementations, except ARGS is
    const.  */
 
-extern void output_command_const (const char *args, int from_tty);
+extern void output_command (const char *args, int from_tty);
 
 extern int val_print_scalar_type_p (struct type *type);
 
-- 
2.13.6


             reply	other threads:[~2018-05-05 15:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-05 15:40 Tom Tromey [this message]
2018-05-21 16:31 ` Tom Tromey
2018-05-21 19:47   ` Joel Brobecker
2018-05-21 20:27     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180505153947.16864-1-tom@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox