Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Julio Guerra <guerr@julio.in>
To: gdb-patches@sourceware.org
Cc: Mike Frysinger <vapier@gentoo.org>
Subject: [PATCH 2/4] Do not clear the value of st_dev in File I/O's stat()
Date: Sat, 28 Apr 2018 01:19:00 -0000	[thread overview]
Message-ID: <20180428011940.115515-3-julio@farjump.io> (raw)
In-Reply-To: <20180428011940.115515-1-julio@farjump.io>

There is no reason to clear st_dev, while it is not in `remote_fileio_func_fstat()`.

2018-04-28  Julio Guerra  <julio@farjump.io>

	* gdb/remote-fileio.c: do not clear the value of st_dev in File I/O's stat().

Signed-off-by: Julio Guerra <julio@farjump.io>
---
 gdb/ChangeLog       | 4 ++++
 gdb/remote-fileio.c | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a9ddac5f98..6986798f08 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2018-04-28  Julio Guerra  <julio@farjump.io>
+
+	* gdb/remote-fileio.c: do not clear the value of st_dev in File I/O's stat().
+
 2018-04-28  Julio Guerra  <julio@farjump.io>
 
 	* gdb/remote-fileio.c: allow using File I/O functions with special
diff --git a/gdb/remote-fileio.c b/gdb/remote-fileio.c
index fa3cb15033..e855c682a0 100644
--- a/gdb/remote-fileio.c
+++ b/gdb/remote-fileio.c
@@ -870,7 +870,6 @@ remote_fileio_func_stat (char *buf)
   if (statptr)
     {
       host_to_fileio_stat (&st, &fst);
-      host_to_fileio_uint (0, fst.fst_dev);
 
       errno = target_write_memory (statptr, (gdb_byte *) &fst, sizeof fst);
       if (errno != 0)
-- 
2.17.0


      parent reply	other threads:[~2018-04-28  1:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-28  1:19 [PATCH 0/4] Some File I/O improvements for embedded programming Julio Guerra
2018-04-28  1:19 ` [PATCH 4/4] Install gdb/fileio.h Julio Guerra
2018-04-28  1:19 ` [PATCH 3/4] Explicit fixed-width integral File I/O protocol types Julio Guerra
2018-05-02 10:46   ` Pedro Alves
     [not found]     ` <332abe88-4b88-3f06-7141-31a798f2b153@farjump.io>
2018-05-02 15:18       ` Julio Guerra
2018-05-02 16:14         ` Joel Brobecker
     [not found]           ` <a5149a53-09e3-2a08-607a-38d81dfa5eac@farjump.io>
2018-05-02 16:31             ` Julio Guerra
2018-04-28  1:19 ` [PATCH 1/4] Remove the restriction of File I/O functions to regular files only Julio Guerra
2018-04-30  1:54   ` Simon Marchi
2018-04-28  1:19 ` Julio Guerra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180428011940.115515-3-julio@farjump.io \
    --to=guerr@julio.in \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox