Re: Re: [PATCH 0/3 v3] [AArch64] Support tagged pointer

Omair Javaid
2018-04-23T07:50:40Z

On 20 April 2018 at 21:13, Daniel Thompson <daniel.thompson@linaro.org> wrote:
>
> On 20/04/18 15:33, Omair Javaid wrote:
>>
>> On 17 April 2018 at 03:57, Pedro Alves <palves@redhat.com> wrote:
>>
>>> On 04/16/2018 02:36 AM, Omair Javaid wrote:
>>>>
>>>> On 11 April 2018 at 23:27, Pedro Alves <palves@redhat.com> wrote:
>>>>
>>>>> On 04/11/2018 12:59 PM, Omair Javaid wrote:
>>>>>
>>>>>> Yes I can submit a patch that enables set_gdbarch_significant_addr_bit
>>>>>
>>>>> for aarch64-linux-tdep only.
>>>>>>
>>>>>>
>>>>>> But a point to discuss here is the use-case where some people use
>>>>>
>>>>> *-linux-gdb for debugging seamlessly between kernel and user-space.
>>>>>>
>>>>>>
>>>>>> There can be ways we can distinguish between user/kernel address space
>>>>>
>>>>> and clear or set top byte of the address even in case of linux targets.
>>>>>>
>>>>>>
>>>>>> Does this sound something we should do?
>>>>>
>>>>>
>>>>> Yeah, why not.
>>>>>
>>>>> What are the pending kernel debugging patches using to distinguish
>>>>> userspace and kernel debugging modes? Off hand, I'd think we'd want to
>>>>> make those separate ABIs / osabis / gdbarchs.
>>>>>
>>>>
>>>> Sorry for late reply on this I am out of office this week.
>>>>
>>>> I have given this a thought and I propose to do the following:
>>>>
>>>> Turn on pointer tagging on OSABI (LINUX) by default.
>>>>
>>>> Add commands set aarch64 pointer-tagging show/enable/disable.
>>>>
>>>> Once LKD patches for aarch64/arm land in our need for this will
>>>> automatically be solved.
>>>
>>>
>>> Makes sense, but I'd like to clarify usefulness of the separate
>>> "set aarch64 pointer-tagging" command.
>>> If indeed we're doing to end up with a separate osabi for the Linux
>>> kernel, then "set osabi linux-kernel" will result
>>> in disabling pointer-tagging too. So, will it still be useful to have
>>> the specific "set aarch64 pointer-tagging" commands? Do you see
>>> use cases for "set aarch64 pointer-tagging" beyond disabling it
>>> for Linux kernel debugging? I'm thinking that it may be useful
>>> for bare metal debugging. But, ideally, GDB would figure it out
>>> on its own without user intervention. Is there's some bit in some
>>> register gdb could read that indicates whether tagging is enabled?
>>>
>>>
>> Pointer tagging information is stored in MMU registers so in linux
>> user-space we cannot actually read if pointer tagging is enabled or not
>> based on register bits.
>> JTAG debuggers should be able to read MMU registers and know whether
>> pointer tagging is enabled or not.
>
>
> Perhaps a dumb question but could gdb be persuaded to mask the pointers at a lower level.
>
> The current patches end up masking the pointer tags relatively early, which results in masked pointers being sent via the gdb remote protocol (which is what causes some of the problems at present: kgdb and OpenOCD get asked for the wrong pointer).
>
> If the pointers were masked as the arguments to ptrace() were marshaled this would behave much more like the real hardware and would make debugging Linux kernel mode entirely transparent (since you cannot ptrace() kernel memory we would never try masking out the tag).

Although this can be done with a hook but will require some
fundamental changes to the way ptrace inf_ptrace_xfer_partial memory
accesses routines are written. Currently we use a generic
implementation inf_ptrace_xfer_partial for all target architectures.
Same is the case with GDBServer it just handles the ptrace calls
except in a few cases where we need extra architecture specific code
before ptrace call like setting hardware breakpoints watchpoints etc.

As top byte in tagged address is essentially data, pushing masking
down to gdbserver will mean that we ll be sending out data mangled as
part of the address. Passing mangled address over RSP expecting other
side will correct it doesnt sound right.

Lets see what Pedro has to see on this.

>
> More generally masking would become the problem of the register read code for the target. I suspect many JTAG debuggers would (and certainly should) already work correctly as their register reads can honour the TTBR0 status.
>
>
> Daniel.