From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104818 invoked by alias); 13 Apr 2018 07:41:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104792 invoked by uid 89); 13 Apr 2018 07:40:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Apr 2018 07:40:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1FD951161D2; Fri, 13 Apr 2018 03:40:57 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id W9GP1s9pTCkP; Fri, 13 Apr 2018 03:40:57 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 63BA21161B3; Fri, 13 Apr 2018 03:40:56 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7F2C983313; Fri, 13 Apr 2018 09:40:52 +0200 (CEST) Date: Fri, 13 Apr 2018 07:41:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/2] Set TYPE_NAME for Rust unions Message-ID: <20180413074052.lxdfiypb3kq6ulp3@adacore.com> References: <20180412190756.16052-1-tom@tromey.com> <20180412190756.16052-3-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180412190756.16052-3-tom@tromey.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-04/txt/msg00248.txt.bz2 > I think that TYPE_TAG_NAME is confusing and should probably be > removed. I am working on a patch to do this, but in the meantime this > seemed like a reasonable change to apply. I suspect this change would > be ok for C++ as well, but I do not know about D. I agree that TYPE_TAG_NAME is confusing, and I would welcome it being removed. > 2018-04-12 Tom Tromey > > * dwarf2read.c (read_structure_type): Set TYPE_NAME for rust > unions. The patch looks good to me, but I'd like to see if others have comments about C++. I'm trying to remember if C++ enums might have different rules compared to C enums, and I'm not remembering any... If there weren't any difference, and things were OK with C enums, one might think that we're OK for C++ enums as well... No way to test this either? -- Joel