From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2682 invoked by alias); 19 Mar 2018 14:29:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2658 invoked by uid 89); 19 Mar 2018 14:29:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Mar 2018 14:29:08 +0000 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2JEQCxB141636 for ; Mon, 19 Mar 2018 10:29:07 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2gte5nj6gt-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Mon, 19 Mar 2018 10:29:06 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 19 Mar 2018 14:29:04 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 19 Mar 2018 14:29:01 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w2JET0c652363290; Mon, 19 Mar 2018 14:29:00 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EB7064C058; Mon, 19 Mar 2018 14:22:09 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DB7C74C04E; Mon, 19 Mar 2018 14:22:09 +0000 (GMT) Received: from oc3748833570.ibm.com (unknown [9.152.213.46]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 19 Mar 2018 14:22:09 +0000 (GMT) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 1D31FD804A7; Mon, 19 Mar 2018 15:29:00 +0100 (CET) Subject: Re: [PATCH] gdbarch: Add pc_signed field and use it when adjusting BP addresses To: macro@mips.com (Maciej W. Rozycki) Date: Mon, 19 Mar 2018 14:29:00 -0000 From: "Ulrich Weigand" Cc: yao.qi@linaro.org (Yao Qi), vlad.ivanov@lab-systems.ru (Vlad Ivanov), schwab@suse.de (Andreas Schwab), gdb-patches@sourceware.org (gdb-patches@sourceware.org) In-Reply-To: from "Maciej W. Rozycki" at Mar 19, 2018 02:08:44 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18031914-0040-0000-0000-00000442DD87 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18031914-0041-0000-0000-000020E5F661 Message-Id: <20180319142900.1D31FD804A7@oc3748833570.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-19_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803190165 X-SW-Source: 2018-03/txt/msg00355.txt.bz2 Maciej W. Rozycki wrote: > On Thu, 15 Mar 2018, Ulrich Weigand wrote: > > > > MIPS backend already returns a sign-extended value, and address_significant > > > cuts out bits 63 to 32. This makes breakpoint address comparison in step > > > routines to misbehave. > > > > If the address is already correct, why don't you simply set > > gdbarch_significant_addr_bit > > to 64 in the mips back-end instead of adding a new gdbarch routine? > > I think it's the default from commit a738ea1d41da ("Clear non-significant > bits of address on memory access") that is wrong. The default is set to > `gdbarch_addr_bit (gdbarch)'. Instead I think it should be set to the BFD > VMA width, i.e. `8 * sizeof (bfd_vma)' or suchlike, so that the internal > representation does not get truncated inadvertently. Good point. I agree it makes sense to change the default here. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com