Re: [RFA] C++-ify typedef hash

Pedro Alves
2018-03-27T10:33:19Z

On 03/27/2018 04:10 AM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> At least this comment should be updated -- there's no "PRINTERS"
> Pedro> parameter any longer.
>
> I just removed this comment, since I couldn't think of a useful comment
> to put before a destructor.
>
>>> + /* Copy a typedef hash. */
>>> + typedef_hash_table (const typedef_hash_table *);
>
> Pedro> This method's prototype gave me pause -- is there a reason this
> Pedro> isn't a regular copy ctor?
>
> I've changed it. I think this was something I meant to do and then
> forgot to complete.
>
> Pedro> But FLAGS isn't a hash table, right? The original comment said:
> Pedro> /* Look up the type T in the typedef hash table in with FLAGS.
> Pedro> ^^^^^^^
> Pedro> I wonder whether that was a typo for "within".
> Pedro> Maybe this could say something about local/global too.
>
> I've rewritten this comment, let me know what you think.

LGTM.

Thanks,
Pedro Alves