Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Update "gdb --configuration"
Date: Fri, 09 Mar 2018 10:57:00 -0000	[thread overview]
Message-ID: <20180309105751.ptsfjpaae5vv35ao@adacore.com> (raw)
In-Reply-To: <838tb1wmrh.fsf@gnu.org>

Hi Eli,

On Fri, Mar 09, 2018 at 12:45:22PM +0200, Eli Zaretskii wrote:
> The patch below adds more config information to the text we produce.
> OK to commit?
> 
> 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
> 
> 	* top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
> 	and LIBMPFR in the printed configuration.

Looks good to me, modulo one tiny think-o below:

> +#if HAVE_LIBMPFR
> +    fprintf_filtered (stream, _("\
> +             --with-libmpfr\n\

It's actually --with-mpfr.

> +"));
> +#else
> +    fprintf_filtered (stream, _("\
> +             --without-libmpfr\n\

Same here.

-- 
Joel


  reply	other threads:[~2018-03-09 10:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09 10:45 Eli Zaretskii
2018-03-09 10:57 ` Joel Brobecker [this message]
2018-03-09 14:01   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180309105751.ptsfjpaae5vv35ao@adacore.com \
    --to=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox