From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58864 invoked by alias); 26 Feb 2018 06:56:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58855 invoked by uid 89); 26 Feb 2018 06:56:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Feb 2018 06:56:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A4C3A1175E1; Mon, 26 Feb 2018 01:56:25 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id oJouzzMoj8CC; Mon, 26 Feb 2018 01:56:25 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4228F116C04; Mon, 26 Feb 2018 01:56:25 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id E407283054; Mon, 26 Feb 2018 10:56:20 +0400 (+04) Date: Mon, 26 Feb 2018 06:56:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA v2 4/4] Handle DW_TAG_variant_part and DW_TAG_variant Message-ID: <20180226065620.z6dzyzrlr72kylnn@adacore.com> References: <20180222203018.23551-1-tom@tromey.com> <20180222203018.23551-5-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180222203018.23551-5-tom@tromey.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-02/txt/msg00375.txt.bz2 > 2018-02-22 Tom Tromey > > * dwarf2read.c (struct variant_field): New. > (struct nextfield) : New field. > (dwarf2_add_field): Handle DW_TAG_variant_part. > (dwarf2_attach_fields_to_type): Attach a discriminant_info to a > discriminated union. > (read_structure_type): Handle DW_TAG_variant_part. > (handle_struct_member_die): New function, extracted from > process_structure_scope. Handle DW_TAG_variant. > (process_structure_scope): Handle discriminated unions. Call > handle_struct_member_die. > > 2018-02-22 Tom Tromey > > * gdb.dwarf2/variant.c: New file. > * gdb.dwarf2/variant.exp: New file. Looks good to me, Tom. Thanks! -- Joel