From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27204 invoked by alias); 26 Feb 2018 04:28:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27166 invoked by uid 89); 26 Feb 2018 04:28:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=wish X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Feb 2018 04:28:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8B4E4116C20; Sun, 25 Feb 2018 23:27:59 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Ix3tlpdHBA+E; Sun, 25 Feb 2018 23:27:59 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2359B1161BD; Sun, 25 Feb 2018 23:27:59 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C034983054; Mon, 26 Feb 2018 08:27:54 +0400 (+04) Date: Mon, 26 Feb 2018 04:28:00 -0000 From: Joel Brobecker To: John Baldwin Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Workaround a FreeBSD ptrace() bug with clearing thread events. Message-ID: <20180226042754.fthsp5demixbwq2l@adacore.com> References: <20180224000935.43344-1-jhb@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180224000935.43344-1-jhb@FreeBSD.org> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-02/txt/msg00371.txt.bz2 Hi John, > gdb/ChangeLog: > > * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a > wildcard process pid for super_resume for kernels with a > specific bug. Just a small coding style nit: > +#if __FreeBSD_version < 1200052 > + /* > + * When multiple threads within a process wish to report STOPPED > + * events from wait(), the kernel picks one thread event as the In the GDB project, we do not use the '*' at the start of every line. See: https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Block_Comment_Formatting -- Joel