Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Xavier Roirand <roirand@adacore.com>,
	GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix frame argument printing when using auto language mode
Date: Thu, 22 Feb 2018 03:38:00 -0000	[thread overview]
Message-ID: <20180222033826.scpiuiper3lhdbtm@adacore.com> (raw)
In-Reply-To: <CAH=s-PNXHw=9peQkB23_g-dKKcXCiBP20tvG9Tbx9mJ5hmR+9A@mail.gmail.com>

Hi Yao,

> We don't have to do that.  ada_val_print_1 is called in ada_val_print,
> 
>       ada_val_print_1 (type, embedded_offset, address,
>        stream, recurse, val, options,
>        current_language);
> 
> and ada_val_print is language->la_val_print in effect, so "language"
> is ada_language_defn, and we can rewrite the code above like this,
> 
>       ada_val_print_1 (type, embedded_offset, address,
>        stream, recurse, val, options,
>        &ada_language_defn);
> 
> This change may break existing behaviour.  Printing for ada (or other
> languages) shouldn't depend on current_language, IMO.

Thanks for the extra pair of eyes, and the pertinent suggestions!
FWIW, I agree with you, your fix is much better.

-- 
Joel


      parent reply	other threads:[~2018-02-22  3:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1519044767-8741-1-git-send-email-roirand@adacore.com>
     [not found] ` <CAH=s-PM+9dGs12pLNDZTcr69tdkTMDdyFhAwhHHL037vkvqCKQ@mail.gmail.com>
2018-02-20 16:28   ` Xavier Roirand
2018-02-20 16:48     ` Yao Qi
2018-02-21 16:12       ` Xavier Roirand
2018-02-22  3:38       ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222033826.scpiuiper3lhdbtm@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    --cc=roirand@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox