From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73997 invoked by alias); 21 Feb 2018 07:37:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73986 invoked by uid 89); 21 Feb 2018 07:37:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Feb 2018 07:37:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AEE1C1162C1; Wed, 21 Feb 2018 02:37:55 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dBZSme7zguhV; Wed, 21 Feb 2018 02:37:55 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 473581162C0; Wed, 21 Feb 2018 02:37:55 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id E4BB883054; Wed, 21 Feb 2018 11:37:50 +0400 (+04) Date: Wed, 21 Feb 2018 07:37:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: GDB Patches , palves@redhat.com, Simon Marchi Subject: Re: [RFC] "gdbserver ... BASENAME_EXE" no longer works Message-ID: <20180221073750.oko5qo3hszesefx6@adacore.com> References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <1482464361-4068-6-git-send-email-sergiodj@redhat.com> <20180221035827.ae265ol4k5jthhp2@adacore.com> <87sh9u50nn.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sh9u50nn.fsf@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-02/txt/msg00283.txt.bz2 Hi Sergio, Thanks for your preliminary answer and the pointers to your own set of patches. I considered doing it for gdbserver only, but thought it was less code doing it there than in in gdbserver directly (you have to handle the case both when the executable is passed via the command-line and the case when it's passed via the remote protocol). But I'm happy with your approach, as it avoids some unnecessary work in the case of GDB (the overhead is a call to lbasename, which is guaranteed to always return a different string than the origin exec_file). I'll send my comments for your patches... -- Joel