From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116678 invoked by alias); 7 Feb 2018 09:02:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116660 invoked by uid 89); 7 Feb 2018 09:02:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Feb 2018 09:02:11 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w178xF3S068175 for ; Wed, 7 Feb 2018 04:02:10 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fyvqg4hrg-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 07 Feb 2018 04:02:09 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 7 Feb 2018 09:02:07 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 7 Feb 2018 09:02:05 -0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w17925am61014240; Wed, 7 Feb 2018 09:02:05 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8C8C142052; Wed, 7 Feb 2018 08:55:01 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6B3CD42057; Wed, 7 Feb 2018 08:55:01 +0000 (GMT) Received: from ThinkPad (unknown [9.152.212.63]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 7 Feb 2018 08:55:01 +0000 (GMT) Date: Wed, 07 Feb 2018 09:02:00 -0000 From: Philipp Rudo To: Yao Qi Cc: Alan Hayward , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h In-Reply-To: References: <97948063-b3db-fd3a-f62e-b552935cb8dd@arm.com> <20180201121443.43322674@ThinkPad> <59984094-96C1-4D84-89F6-384769471005@arm.com> <86k1vqjd5s.fsf@gmail.com> <20180206185609.3219ef39@ThinkPad> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18020709-0040-0000-0000-0000040D3858 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18020709-0041-0000-0000-00002610E909 Message-Id: <20180207100202.1ea997bb@ThinkPad> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-07_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802070113 X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00099.txt.bz2 Hi Yao, sorry, i misunderstood you. You are right cleaning up gdbservers Makefile would be better. I'm currently pretty occupied, but I can give it a try later on. Let's see what I can do. Philipp On Tue, 6 Feb 2018 21:24:35 +0000 Yao Qi wrote: > On Tue, Feb 6, 2018 at 5:56 PM, Philipp Rudo wrote: > > Of course you could name the *.h file anything you want. But from my point of > > view the *.c and *.h files belonging together should have the same name. > > Having this in mind you cannot call it common/tdesc.h because in > > gdbserver/Makefile:OBS the directory is ignored and both (common/tdesc.c and > > gdbserver/tdec.c) would be compiled to tdesc.o, (most likely) leading to > > unintended behavior. > > What I want is to compile gdbserver/tdesc.c to tdesc.o, common/tdesc.c to > common/tdesc.o in gdbserver build directory. > > > > >> > My next set of patches will then add common/tdesc.c. > >> > This is slightly more tricky because we now build two tdesc.o files. > >> > >> I am inclined to create common/ directory in gdb and gdbserver build > >> tree, and put the object files in the right directory. > > > > Yao, what do you mean with this? There already is a common/ directory with > > code shared by gdb and gdbserver. The thing is that tdesc.h was in arch/ not > > in common/. Alan, Omair (if I recall right) and I agreed that it would be > > better to move it to common/ because arch/ should only contain architecture > > specific code. Or am I understanding you wrong? > > > > It is build tree, instead of source tree. What I want is to have common/ in gdb > and gdbserver build directory respectively. I am not against moving > arch/tdesc.h > to common/tdesc.h. >