From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66449 invoked by alias); 6 Feb 2018 17:56:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66389 invoked by uid 89); 6 Feb 2018 17:56:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=belonging, Hx-languages-length:1779 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Feb 2018 17:56:28 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w16Hs3Jf058476 for ; Tue, 6 Feb 2018 12:56:26 -0500 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fyg4xk3sn-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 06 Feb 2018 12:56:25 -0500 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 6 Feb 2018 17:56:23 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 6 Feb 2018 17:56:11 -0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w16HuBp626738814; Tue, 6 Feb 2018 17:56:11 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DB81A42049; Tue, 6 Feb 2018 17:49:08 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B1D6742041; Tue, 6 Feb 2018 17:49:08 +0000 (GMT) Received: from ThinkPad (unknown [9.152.212.63]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 6 Feb 2018 17:49:08 +0000 (GMT) Date: Tue, 06 Feb 2018 17:56:00 -0000 From: Philipp Rudo To: Yao Qi Cc: Alan Hayward , "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h In-Reply-To: <86k1vqjd5s.fsf@gmail.com> References: <97948063-b3db-fd3a-f62e-b552935cb8dd@arm.com> <20180201121443.43322674@ThinkPad> <59984094-96C1-4D84-89F6-384769471005@arm.com> <86k1vqjd5s.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 x-cbid: 18020617-0008-0000-0000-000004CA0BC9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18020617-0009-0000-0000-00001E5DB989 Message-Id: <20180206185609.3219ef39@ThinkPad> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-06_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802060227 X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00091.txt.bz2 Hi Yao, On Tue, 06 Feb 2018 16:28:15 +0000 Yao Qi wrote: > Alan Hayward writes: >=20 > > That results in common/tdesc.h and gdbserver/tdesc.h > > That=E2=80=99s not a problem by itself, because we can just prefix the = dir > > name as part of the include. > >=20=20 >=20 > I don't see how does the name of *.c file affect the name of *.h file. > We can still use common/tdesc.h no matter what the *.c name is. Of course you could name the *.h file anything you want. But from my point= of view the *.c and *.h files belonging together should have the same name. Having this in mind you cannot call it common/tdesc.h because in gdbserver/Makefile:OBS the directory is ignored and both (common/tdesc.c and gdbserver/tdec.c) would be compiled to tdesc.o, (most likely) leading to unintended behavior. =20 > > My next set of patches will then add common/tdesc.c. > > This is slightly more tricky because we now build two tdesc.o files.=20= =20 >=20 > I am inclined to create common/ directory in gdb and gdbserver build > tree, and put the object files in the right directory. Yao, what do you mean with this? There already is a common/ directory with code shared by gdb and gdbserver. The thing is that tdesc.h was in arch/ n= ot in common/. Alan, Omair (if I recall right) and I agreed that it would be better to move it to common/ because arch/ should only contain architecture specific code. Or am I understanding you wrong? Philipp > > The gdbserver IPA rules will need tweaking, and I=E2=80=99m not sure th= e OBS > > list will work as it is (given it doesn=E2=80=99t have any dir names). > > > > Like you, I wasn=E2=80=99t sure if there was a naming convention for co= mmon/. > > In the end I went with the easiest solution :)=20=20 >=20