From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57938 invoked by alias); 5 Feb 2018 19:44:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57920 invoked by uid 89); 5 Feb 2018 19:44:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=enjoy!, enjoy X-HELO: mail-wm0-f54.google.com Received: from mail-wm0-f54.google.com (HELO mail-wm0-f54.google.com) (74.125.82.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Feb 2018 19:44:08 +0000 Received: by mail-wm0-f54.google.com with SMTP id x4-v6so14635904wmc.0 for ; Mon, 05 Feb 2018 11:44:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EyamqBvbtGfVGdpo8qvp6bJnJyhPUrTTZiUIgbuBzlU=; b=rmMdTq2U9IP5Tf3/fyfu56PCW3L3xqF/hfrM6hpxZtY3XHJwMbsH0KUysHoRYDDtmV CLitwEb7HxqZK5xn7oWlin6B4iUlpki6PVDJF9lL77ZjumCrzSalNO7QQobLgSZX8nKe m3nScH/vcHHJWvFEG+9SZr6yBg7jrtpkke/ZpF+yxP++i5dbcngIjatynYFI0+UMowNS VybSRI7KHtqueRl4mcpvcpMJcqU6kuSCpfPtdZs30hOdua2fh3uBaY2bgL1KG5cbz+Iv YODIyydR211eURCaETrgyGMRvbxaD9751VOYUGN7kcGLVoOJWKjgaCxECFYTwfP1zixF rQyA== X-Gm-Message-State: APf1xPAZZfDA8Ns+rUjCdlUtpZtQttc99MV8BROsZu51ZncXahBPCQzY SckRbClRYN8crgzEalJxGkLNcg== X-Google-Smtp-Source: AH8x226WKy9BWevMEdk+7vAJPVLfZ++FqpseibmrGR+XHMdGDpFpELW4THaawrlIAs7BGa7z1vXl3A== X-Received: by 10.28.99.137 with SMTP id x131mr343859wmb.12.1517859846891; Mon, 05 Feb 2018 11:44:06 -0800 (PST) Received: from localhost (host86-152-213-123.range86-152.btcentralplus.com. [86.152.213.123]) by smtp.gmail.com with ESMTPSA id d17sm10637916wrc.38.2018.02.05.11.44.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Feb 2018 11:44:06 -0800 (PST) Date: Mon, 05 Feb 2018 19:44:00 -0000 From: Andrew Burgess To: John Baldwin Cc: gdb-patches@sourceware.org Subject: Re: Stop updating ChangeLog? Message-ID: <20180205194405.GD2778@embecosm.com> References: <2329026.M5dy4NNrbC@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2329026.M5dy4NNrbC@ralph.baldwin.cx> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.1 (2017-09-22) X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00076.txt.bz2 * John Baldwin [2018-02-05 11:07:16 -0800]: > On Monday, February 05, 2018 04:00:36 PM Yao Qi wrote: > > Hi all, > > The discussion in this thread > > https://sourceware.org/ml/gdb-patches/2018-02/msg00012.html > > leads to a discussion that whether we still need ChangeLog. I start > > a new thread to get more attention on this topic. > > > > In current development, we need to write one ore more changelog > > entries for each commit, put them into both git commit log and > > ChangeLog files. How much we can change to existing mode > > depends the answers to these following questions, > > > > #1 Are ChangeLog files useful in GDB releases to various people > > who build GDB releases? > > #2 Are ChangeLog files useful in GDB repo to various GDB > > developers? > > > > a) If answers are Yes/Yes, we keep unchanged, > > b) If answers are No/No, we don't need to write changelog entries in > > git commit log, nor updating ChangeLog file, > > c) If answer are Yes/No, developers still have to write changelog > > entries in git commit log, and we can generate ChangeLog on > > release from git log. > > d) If answers are No/Yes, get use to git to get the information from > > git log instead of ChangeLog, > > > > My answers are No/No, so I suggest that we do b). I can live up with > > c), but that needs change in the release process. What do you think? > > I probably have a bit of a biased view as most of my development work is done > without ChangeLogs, so I'm used to just using web interfaces (svnweb, gitweb) > or vc-annotate in Emacs or the like (git log -S is also super helpful) when > examining history. I also find the contents of a ChangeLog as I currently > understand it to be a description of the diff (but not the "why"), so I find > it to be redundant with 'git diff' rather than providing new information (as > opposed to the "why" we currently include in commit messages). That probably > puts me in the No/No camp. > > c) would save some work on having to always do 'rebase -i' passes to fixup > dates in the ChangeLog files before pushing an approved series. (I use > git-merge-changelog which at last moves the added entries to the top, but I > still have to go fixup all the dates by hand.) You might find this useful: https://github.com/T-J-Teru/dotfiles/blob/master/home/bin/git-update-changelogs Where previously you would do: git rebase -i BASE-COMMIT # Edit each commit to update the date by hand... You can now just do: git update-changelogs BASE-COMMIT And you're done. Enjoy! Thanks, Andrew