From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58157 invoked by alias); 3 Feb 2018 16:53:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58106 invoked by uid 89); 3 Feb 2018 16:53:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f171.google.com Received: from mail-wr0-f171.google.com (HELO mail-wr0-f171.google.com) (209.85.128.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 03 Feb 2018 16:53:33 +0000 Received: by mail-wr0-f171.google.com with SMTP id a43so17916087wrc.4 for ; Sat, 03 Feb 2018 08:53:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=THEFmU4wVhBGnosdrJWHGVekkOldxG/Rz8MjJPdeeQE=; b=TJxeuOsudLl82GAKff77Uwsy2UKdF0bConLa9juXV42K0cmmL5CfAlgL8+7DHHuRD0 rhr5Z825FWm7reGCqobzezGJ5HYf3OGUBN82T+135iEPn6qSgeKto4t596WwCM9pUlhU EugB0THhdU8F+W44ZyCaGpt4n3JibqPby2IvcDt9rGoAjLsO9ixEMyIhR4OA0RjNDgY4 CKe8fgyF59zonQfS+Iwy6f39bswU/qqQCfy0D2xCxKyz3UFSDov6yJXf4UaZtMrQOETg PnDUuqHKQZ324AtpEajed5HK8c1JDE3UjsUOo0rujxMc9OZdS+vgpdCjqZ/cVSr4kZar 1xGQ== X-Gm-Message-State: AKwxyteW5GmW9K+Sv7EiQh+Q2zsjjqxL0DVop7OnV2MfHN+L8QBgt0Ra s6ZzF1zG6hQIbRXMyfWGnqq7Yw== X-Google-Smtp-Source: AH8x227/tSMtTAqV7+QYWFUiiQ5jgTgLzbV4QShfVgDsm5hW6hYLi2D3oAsQy2CMl7yfXO8ELbx0hw== X-Received: by 10.223.152.193 with SMTP id w59mr17475201wrb.74.1517676811791; Sat, 03 Feb 2018 08:53:31 -0800 (PST) Received: from localhost (host86-152-213-123.range86-152.btcentralplus.com. [86.152.213.123]) by smtp.gmail.com with ESMTPSA id v75sm14142615wrb.12.2018.02.03.08.53.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Feb 2018 08:53:30 -0800 (PST) Date: Sat, 03 Feb 2018 16:53:00 -0000 From: Andrew Burgess To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: Remove use of dejagnu cleanup proc Message-ID: <20180203165329.GG3162@embecosm.com> References: <20180202125638.7365-1-andrew.burgess@embecosm.com> <128bdd85091849dc53eea059b13fabce@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <128bdd85091849dc53eea059b13fabce@polymtl.ca> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.1 (2017-09-22) X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00052.txt.bz2 * Simon Marchi [2018-02-02 23:59:07 -0500]: > On 2018-02-02 07:56, Andrew Burgess wrote: > > The 'cleanup' proc has been removed from dejagnu (Feb 15 2016). The > > proc has not done anything useful since at least 2001 so removing > > these calls should be harmless. > > > > gdb/testsuite/ChangeLog: > > > > * config/sid.exp (gdb_target_sid): Remove use of cleanup. > > * config/sim.exp (gdb_target_sim): Remove use of cleanup. > > --- > > gdb/testsuite/ChangeLog | 5 +++++ > > gdb/testsuite/config/sid.exp | 2 -- > > gdb/testsuite/config/sim.exp | 1 - > > 3 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/gdb/testsuite/config/sid.exp b/gdb/testsuite/config/sid.exp > > index 36bd8611966..8ff0263b618 100644 > > --- a/gdb/testsuite/config/sid.exp > > +++ b/gdb/testsuite/config/sid.exp > > @@ -146,7 +146,6 @@ proc gdb_target_sid { } { > > gdb_expect { > > -re ".*\[Ee\]rror.*$gdb_prompt $" { > > perror "Couldn't set target for remote simulator." > > - cleanup > > gdb_exit > > } > > -re "Remote debugging using.*$gdb_prompt" { > > @@ -154,7 +153,6 @@ proc gdb_target_sid { } { > > } > > timeout { > > perror "Couldn't set target for remote simulator." > > - cleanup > > gdb_exit > > } > > } > > diff --git a/gdb/testsuite/config/sim.exp b/gdb/testsuite/config/sim.exp > > index 7170a259837..d9072febc6a 100644 > > --- a/gdb/testsuite/config/sim.exp > > +++ b/gdb/testsuite/config/sim.exp > > @@ -34,7 +34,6 @@ proc gdb_target_sim { } { > > } > > timeout { > > perror "Couldn't set target for simulator." > > - cleanup > > return -1 > > } > > } > > LGTM. > > I guess with a recent Dejagnu it would produce an error to try to run it > then? Well, all the uses are on error paths, so, you're fine unless you're failing... then you crash rather than simply failing one test and continuing. I'll go ahead and push this in. Thanks, Andrew