From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCH] gdb/testsuite: Remove use of dejagnu cleanup proc
Date: Fri, 02 Feb 2018 12:56:00 -0000 [thread overview]
Message-ID: <20180202125638.7365-1-andrew.burgess@embecosm.com> (raw)
The 'cleanup' proc has been removed from dejagnu (Feb 15 2016). The
proc has not done anything useful since at least 2001 so removing
these calls should be harmless.
gdb/testsuite/ChangeLog:
* config/sid.exp (gdb_target_sid): Remove use of cleanup.
* config/sim.exp (gdb_target_sim): Remove use of cleanup.
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/config/sid.exp | 2 --
gdb/testsuite/config/sim.exp | 1 -
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/config/sid.exp b/gdb/testsuite/config/sid.exp
index 36bd8611966..8ff0263b618 100644
--- a/gdb/testsuite/config/sid.exp
+++ b/gdb/testsuite/config/sid.exp
@@ -146,7 +146,6 @@ proc gdb_target_sid { } {
gdb_expect {
-re ".*\[Ee\]rror.*$gdb_prompt $" {
perror "Couldn't set target for remote simulator."
- cleanup
gdb_exit
}
-re "Remote debugging using.*$gdb_prompt" {
@@ -154,7 +153,6 @@ proc gdb_target_sid { } {
}
timeout {
perror "Couldn't set target for remote simulator."
- cleanup
gdb_exit
}
}
diff --git a/gdb/testsuite/config/sim.exp b/gdb/testsuite/config/sim.exp
index 7170a259837..d9072febc6a 100644
--- a/gdb/testsuite/config/sim.exp
+++ b/gdb/testsuite/config/sim.exp
@@ -34,7 +34,6 @@ proc gdb_target_sim { } {
}
timeout {
perror "Couldn't set target for simulator."
- cleanup
return -1
}
}
--
2.14.3
next reply other threads:[~2018-02-02 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 12:56 Andrew Burgess [this message]
2018-02-03 4:59 ` Simon Marchi
2018-02-03 16:53 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202125638.7365-1-andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox