From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6905 invoked by alias); 31 Jan 2018 04:45:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129342 invoked by uid 89); 31 Jan 2018 04:45:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Jan 2018 04:45:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AEA6C563B3; Tue, 30 Jan 2018 23:45:22 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dwtiNnjOTkgH; Tue, 30 Jan 2018 23:45:22 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4C7A9563AF; Tue, 30 Jan 2018 23:45:22 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 1D92383307; Wed, 31 Jan 2018 08:45:18 +0400 (+04) Date: Wed, 31 Jan 2018 04:45:00 -0000 From: Joel Brobecker To: Xavier Roirand Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] (Ada) Add gdb-mi support for stopping at start of exception handler. Message-ID: <20180131044518.6fikahefenihakv3@adacore.com> References: <20180123114306.b6w2csxzygomqlnd@adacore.com> <1517304252-15603-1-git-send-email-roirand@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517304252-15603-1-git-send-email-roirand@adacore.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-01/txt/msg00645.txt.bz2 On Tue, Jan 30, 2018 at 10:24:12AM +0100, Xavier Roirand wrote: > Following my previous commit which add support for stopping at start of > exception handler, this commit adds required gdb-mi support for this > feature. > > gdb/ChangeLog: > > * mi/mi-cmd-catch.c (mi_cmd_catch_handlers): New function. > * mi/mi-cmds.c (mi_cmds): Add catch-handlers command. > * mi/mi-cmds.h (mi_cmd_catch_handlers): Add external declaration. > * NEWS: Document "-catch-handlers" command. > > gdb/doc/ChangeLog: > > * gdb.texinfo (Ada Exception gdb/mi Catchpoints): Add > documentation for new "-catch-handlers" command. > > gdb/testsuite/ChangeLog: > > * gdb.ada/mi_catch_ex_hand.exp: New testcase. > * gdb.ada/mi_catch_ex_hand/foo.adb: New file. > > Tested on x86_64-linux. One minor issue where you misunderstood what I was suggesting: > +# We don't have the exception name info when stopping at the exception handlers > +# breakpoints so we use source line to check if the inferior stops at the I wasn't suggesting you pluralize "breakpoints" (although, not a bad idea), but rather use "catchpoint" rather than "breakpoint". From the user's perspective, we are stopping at a catchpoint, not a breakpoint. Pre-approved with that change made. -- Joel