From: Joel Brobecker <brobecker@adacore.com>
To: Xavier Roirand <roirand@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] (Ada) C++fy conditional string when catching exception.
Date: Wed, 31 Jan 2018 04:41:00 -0000 [thread overview]
Message-ID: <20180131044057.6gqbhdksqvlhkkx7@adacore.com> (raw)
In-Reply-To: <1517304232-15552-1-git-send-email-roirand@adacore.com>
> This commit C++fy the conditional string used when catching Ada exception.
>
> gdb/ChangeLog:
>
> * ada-lang.c (catch_ada_exception_command_split)
> (create_ada_exception_catchpoint) <cond_string>: Change parameter
> type. Update code accordingly.
> (catch_ada_exception_command, catch_ada_handlers_command): Use
> C++ string instead of char* for conditional var.
> (catch_ada_assert_command_split) <cond_string>: Change parameter
> type. Update code accordingly.
> (catch_assert_command): Use C++ string instead of char* for
> conditional var.
> * ada-lang.h (create_ada_exception_catchpoint) <cond_string>:
> Update declaration.
> * mi/mi-cmd-catch.c (mi_cmd_catch_assert, mi_cmd_catch_exception):
> Use std::string instead of char* for condition string.
Approved.
Thank you,
--
Joel
next prev parent reply other threads:[~2018-01-31 4:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 9:15 [RFAv2] (Ada) Add gdb-mi support for stopping at start of exception handler Xavier Roirand
2018-01-08 18:38 ` Eli Zaretskii
2018-01-23 11:43 ` Joel Brobecker
2018-01-29 12:46 ` [PATCH 1/4] (Ada) Add testcase for catch assert with condition Xavier Roirand
2018-01-30 4:41 ` Joel Brobecker
2018-01-29 12:47 ` [PATCH 4/4] (Ada) Add gdb-mi support for stopping at start of exception handler Xavier Roirand
2018-01-29 15:57 ` Eli Zaretskii
2018-01-30 7:13 ` Joel Brobecker
2018-01-29 12:47 ` [PATCH 2/4] (Ada/MI) Add testcase for mi catch assert with condition Xavier Roirand
2018-01-30 4:49 ` Joel Brobecker
2018-01-29 12:47 ` [PATCH 3/4] (Ada) C++fy conditional string when catching exception Xavier Roirand
2018-01-30 4:57 ` Joel Brobecker
2018-01-30 9:23 ` [PATCHv2 1/4] (Ada) Add testcase for catch assert with condition Xavier Roirand
2018-01-31 4:37 ` Joel Brobecker
2018-01-31 12:52 ` pushed: [PATCH " Xavier Roirand
2018-01-31 12:53 ` [PATCH 3/4] (Ada) C++fy conditional string when catching exception Xavier Roirand
2018-01-31 12:53 ` [PATCH 2/4] (Ada/MI) Add testcase for mi catch assert with condition Xavier Roirand
2018-01-31 12:54 ` pushed: " Xavier Roirand
2018-01-31 12:54 ` pushed: [PATCH 3/4] (Ada) C++fy conditional string when catching exception Xavier Roirand
2018-01-31 12:54 ` pushed: [PATCH] (Ada) Add gdb-mi support for stopping at start of exception handler Xavier Roirand
2018-01-31 13:03 ` pushed: [PATCH 4/4] " Xavier Roirand
2018-01-30 9:23 ` [PATCH 2/4] (Ada/MI) Add testcase for mi catch assert with condition Xavier Roirand
2018-01-31 4:39 ` Joel Brobecker
2018-01-30 9:24 ` [PATCH 3/4] (Ada) C++fy conditional string when catching exception Xavier Roirand
2018-01-31 4:41 ` Joel Brobecker [this message]
2018-01-30 9:24 ` [PATCH 4/4] (Ada) Add gdb-mi support for stopping at start of exception handler Xavier Roirand
2018-01-31 4:45 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180131044057.6gqbhdksqvlhkkx7@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=roirand@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox