From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6063 invoked by alias); 25 Jan 2018 13:11:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6054 invoked by uid 89); 25 Jan 2018 13:11:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=receipt X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Jan 2018 13:11:48 +0000 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0PD4M7U005246 for ; Thu, 25 Jan 2018 08:11:46 -0500 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 2fqfa79ty6-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 25 Jan 2018 08:11:45 -0500 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Jan 2018 13:11:43 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 25 Jan 2018 13:11:40 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w0PDBd2a47251468; Thu, 25 Jan 2018 13:11:39 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0C1B14C058; Thu, 25 Jan 2018 13:05:43 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DBC9D4C040; Thu, 25 Jan 2018 13:05:42 +0000 (GMT) Received: from ThinkPad (unknown [9.152.212.63]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 25 Jan 2018 13:05:42 +0000 (GMT) Date: Thu, 25 Jan 2018 13:11:00 -0000 From: Philipp Rudo To: Alan Hayward Cc: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 0/8] Remove XML files from gdbserver In-Reply-To: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> References: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18012513-0040-0000-0000-00000428BB8A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18012513-0041-0000-0000-000020CC4539 Message-Id: <20180125141138.701802b4@ThinkPad> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-25_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=9 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801250178 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00520.txt.bz2 Hi Alan, in general the series looks fine for me. Just some nits/suggestions. Philipp On Wed, 24 Jan 2018 09:26:10 +0000 Alan Hayward wrote: > Following review comments from Yao, this patch series is mostly a > reordering of the code from the previous patch series. > > This set of patches removes the need for gdbserver to ship the xml files > in the binary for those targets that use new style target descriptions. > > In exisiting code, gdbserver uses C code auto generated from xml files to > create target descriptions. When sending an xml description to GDB, it > creates an xml containing just the name of the original xml file. > Upon receipt, GDB reads and parses a local copy of xml file. > > With this new patch, we add common code that allows gdbserver and gdb > to turn a C target description structure into xml. To do this we must > first ensure that when gdbserver parses a target description it retains > enough information to turn it back into xml. > > The second patch commonises tdesc_reg, the third patch commonises > tdesc_feature and the fifth patch commonises the tdesc type structures. > This enables gdbserver to store all required information about a target > description. > > The sixth patch adds the xml printer. > The other patches are clean up patches. > > Patches have been tested on a make check on x86 targets=all build with > target board unix native-gdbserver. Also tested aarch64. Built for power > (becuase it does not use new target descriptions), but am unable to test. > In addition, patch four adds new test cases to unit test. > > Alan. > > > gdb/Makefile.in | 1 - > gdb/arch/tdesc.c | 425 ------------------------ > gdb/arch/tdesc.h | 307 +----------------- > gdb/features/aarch64-core.c | 2 +- > gdb/features/aarch64-fpu.c | 2 +- > gdb/features/i386/32bit-avx.c | 2 +- > gdb/features/i386/32bit-avx512.c | 2 +- > gdb/features/i386/32bit-core.c | 2 +- > gdb/features/i386/32bit-linux.c | 2 +- > gdb/features/i386/32bit-mpx.c | 2 +- > gdb/features/i386/32bit-pkeys.c | 2 +- > gdb/features/i386/32bit-sse.c | 2 +- > gdb/features/i386/64bit-avx.c | 2 +- > gdb/features/i386/64bit-avx512.c | 2 +- > gdb/features/i386/64bit-core.c | 2 +- > gdb/features/i386/64bit-linux.c | 2 +- > gdb/features/i386/64bit-mpx.c | 2 +- > gdb/features/i386/64bit-pkeys.c | 2 +- > gdb/features/i386/64bit-segments.c | 2 +- > gdb/features/i386/64bit-sse.c | 2 +- > gdb/features/i386/x32-core.c | 2 +- > gdb/features/tic6x-c6xp.c | 2 +- > gdb/features/tic6x-core.c | 2 +- > gdb/features/tic6x-gp.c | 2 +- > gdb/gdbserver/Makefile.in | 3 - > gdb/gdbserver/configure.srv | 36 +++ > gdb/gdbserver/tdesc.c | 229 +++++++------ > gdb/gdbserver/tdesc.h | 58 +++- > gdb/regformats/regdat.sh | 5 +- > gdb/target-descriptions.c | 924 +++++++++++++++++++++++++++++++++++++++-------------- > gdb/xml-tdesc.c | 9 - > gdb/xml-tdesc.h | 5 - > 32 files changed, 920 insertions(+), 1124 deletions(-) >