From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Cc: gdb-patches@sourceware.org
Subject: Re: Oh dear. I regret to inform you that commit 9e390558cef76767a98123994c422d0642d86cf8 might be unfortunate
Date: Wed, 17 Jan 2018 10:56:00 -0000 [thread overview]
Message-ID: <20180117105626.GY20622@bubble.grove.modra.org> (raw)
In-Reply-To: <9e390558cef76767a98123994c422d0642d86cf8-master-breakage@gdb-build>
On Wed, Jan 17, 2018 at 03:29:33AM -0500, gdb-buildbot@sergiodj.net wrote:
> My lords, ladies, gentlemen, members of the public.
>
> It is a matter of great regret and sadness to inform you that commit:
>
> PowerPC PLT stub tidy
> 9e390558cef76767a98123994c422d0642d86cf8
>
> might have made GDB unwell.
Hmm, not seen with my gcc-7 but this ought to cure the warning.
* elf64-ppc.c (ppc64_elf_build_stubs): Silence gcc warning.
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 1b4404c..65cf7fe 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -13211,7 +13211,7 @@ ppc64_elf_build_stubs (struct bfd_link_info *info,
p += 4;
}
p = output_bctr (htab, htab->glink->owner, p);
- BFD_ASSERT (p - htab->glink->contents == GLINK_PLTRESOLVE_SIZE (htab));
+ BFD_ASSERT (p == htab->glink->contents + GLINK_PLTRESOLVE_SIZE (htab));
/* Build the .glink lazy link call stubs. */
indx = 0;
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2018-01-17 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 8:29 gdb-buildbot
2018-01-17 8:29 ` Breakage on builder Ubuntu-AArch32-native-extended-gdbserver-m32, revision 9e390558cef76767a98123994c422d0642d86cf8 gdb-buildbot
2018-01-17 8:38 ` Breakage on builder Ubuntu-AArch32-native-gdbserver-m32, " gdb-buildbot
2018-01-17 8:40 ` Breakage on builder Ubuntu-AArch32-m32, " gdb-buildbot
2018-01-17 10:56 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117105626.GY20622@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox