From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82584 invoked by alias); 16 Jan 2018 18:05:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82568 invoked by uid 89); 16 Jan 2018 18:05:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Jan 2018 18:05:14 +0000 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0GHxAq1098358 for ; Tue, 16 Jan 2018 13:05:12 -0500 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 2fhkkrrqh7-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 16 Jan 2018 13:05:12 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Jan 2018 18:05:10 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 16 Jan 2018 18:05:09 -0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w0GI582E62980226; Tue, 16 Jan 2018 18:05:08 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2E6545204C; Tue, 16 Jan 2018 16:57:39 +0000 (GMT) Received: from oc3748833570.ibm.com (unknown [9.152.213.76]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1EE6752049; Tue, 16 Jan 2018 16:57:39 +0000 (GMT) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 3F01CD804E3; Tue, 16 Jan 2018 19:05:08 +0100 (CET) Subject: Re: [PATCH 01/15] Call cooked_read in ppu2spu_prev_register To: qiyaoltc@gmail.com (Yao Qi) Date: Tue, 16 Jan 2018 18:05:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <86bmhtg4ih.fsf@gmail.com> from "Yao Qi" at Jan 16, 2018 04:19:50 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18011618-0016-0000-0000-000005187511 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18011618-0017-0000-0000-00002854E722 Message-Id: <20180116180508.3F01CD804E3@oc3748833570.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-16_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801160248 X-SW-Source: 2018-01/txt/msg00314.txt.bz2 Hi Yao, > > The code in ppu2spu_prev_register is in fact regcache_cooked_read, > > because spu doesn't have gdbarch method pseudo_register_read_value. > > > > gdb: > > > > 2017-11-06 Yao Qi > > > > * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read. > > Hi Ulrich, > Can you review this patch? Yes, this patch is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com