From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101984 invoked by alias); 8 Jan 2018 04:05:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101970 invoked by uid 89); 8 Jan 2018 04:05:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:05e600e, H*f:sk:05e600e X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Jan 2018 04:04:56 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 105A0117551; Sun, 7 Jan 2018 23:04:55 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tD-7iINXVZPb; Sun, 7 Jan 2018 23:04:55 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9E847117444; Sun, 7 Jan 2018 23:04:54 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 4EA468304F; Mon, 8 Jan 2018 08:04:50 +0400 (+04) Date: Mon, 08 Jan 2018 04:05:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix gdb.ada/complete.exp's "complete break ada" test (PR, gdb/22670) (Re: [PATCH 2/3] Add "complete break ada" test to gdb.ada/complete.exp) Message-ID: <20180108040450.lb3jpho6ghmkf5mx@adacore.com> References: <1515054953-81012-1-git-send-email-brobecker@adacore.com> <1515054953-81012-3-git-send-email-brobecker@adacore.com> <05e600e1-c48c-de04-7e33-2c962b75bc25@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05e600e1-c48c-de04-7e33-2c962b75bc25@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-01/txt/msg00150.txt.bz2 Hi Pedro, > >From 2805fc780e497535f3966dea932023cad9b92b61 Mon Sep 17 00:00:00 2001 > From: Pedro Alves > Date: Fri, 5 Jan 2018 12:21:25 +0000 > Subject: [PATCH 2/2] Fix gdb.ada/complete.exp's "complete break ada" test (PR > gdb/22670) [...] > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > PR gdb/22670 > * ada-lang.c (ada_collect_symbol_completion_matches): If the > minsym's language is language_auto or language_cplus, pass down > language_ada instead. > * symtab.c (compare_symbol_name): Don't frob symbol language here. > > gdb/testsuite/ChangeLog: > yyyy-mm-dd Pedro Alves > > PR gdb/22670 > * gdb.ada/complete.exp ("complete break ada"): Replace kfail with > a fail. Thanks Pedro! This patch looks good to me. In a way, I'm glad the Ada exception is moving back to an ada-* file... FTR, I tested this patch on x86_64-linux against AdaCore's testsuite as well. -- Joel