From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96124 invoked by alias); 8 Jan 2018 03:57:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96109 invoked by uid 89); 8 Jan 2018 03:57:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Jan 2018 03:57:30 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0D129117444; Sun, 7 Jan 2018 22:57:29 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id JjkHfOjXCOBF; Sun, 7 Jan 2018 22:57:28 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 99974117443; Sun, 7 Jan 2018 22:57:28 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 3AD108304F; Mon, 8 Jan 2018 07:57:24 +0400 (+04) Date: Mon, 08 Jan 2018 03:57:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670) (Re: [PATCH 3/3] Add new gdb.ada/bp_c_mixed_case testcase for PR gdb/22670) Message-ID: <20180108035724.gac5u77znunzhho3@adacore.com> References: <1515054953-81012-1-git-send-email-brobecker@adacore.com> <1515054953-81012-4-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-01/txt/msg00149.txt.bz2 Hi Pedro, On Fri, Jan 05, 2018 at 04:34:39PM +0000, Pedro Alves wrote: > On 01/04/2018 08:35 AM, Joel Brobecker wrote: > > This patch adds a new testcase to demonstrate a regression introduced by: > > > > commit b5ec771e60c1a0863e51eb491c85c674097e9e13 > > Date: Wed Nov 8 14:22:32 2017 +0000 > > Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching > > > > The purpose of the testcase is to verify that a user can insert > > a breakpoint on a C function while debugging Ada, even if the name > > of the function includes uppercase letters, requiring us to use > > Ada's "<...>" notation to tell the GDB that the symbol name should > > be looked up verbatim. > > > > As of the commit above, GDB is no longer finding the function: > > > > (gdb) break > > Function "" not defined. > > Make breakpoint pending on future shared library load? (y or [n]) > > > > Before the patch, the breakpoint was inserted without problem. > > > > Below's a fix for this one. Thanks! I confirm the test now passes for me as well :). I have a question though: > >From 439f8c51ff8f6cd9fb3bbc330a40492a15992add Mon Sep 17 00:00:00 2001 > From: Pedro Alves > Date: Fri, 5 Jan 2018 00:17:19 +0000 > Subject: [PATCH 1/2] Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670) > > The problem here is that we were using the user-provided lookup name > literally for linkage name comparisons. I.e., "" with the > "<>"s included. That obviously can't work since the "<>" are not > really part of the linkage name. The original idea was that we'd use > the symbol's language to select the right symbol name matching > algorithm, but that doesn't work for Ada because it's not really > possible to unambiguously tell from the linkage name alone whether > we're dealing with Ada symbols, so Ada minsyms end up with no language > set, or sometimes C++ set. So fix this by treating Ada mode specially > when determining the linkage name to match against. I am wondering why minimal symbols are involved in this case, considering that the C file was build with debugging information. Shouldn't we be getting the function's address from the partial/full symtabs instead? -- Joel