From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81501 invoked by alias); 3 Jan 2018 04:33:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81485 invoked by uid 89); 3 Jan 2018 04:33:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jan 2018 04:33:51 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DA94D11753D; Tue, 2 Jan 2018 23:33:49 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dBVhN2XoppCc; Tue, 2 Jan 2018 23:33:49 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7A3CC1172D1; Tue, 2 Jan 2018 23:33:49 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 0CC58809B6; Wed, 3 Jan 2018 08:33:45 +0400 (+04) Date: Wed, 03 Jan 2018 04:33:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFC] regresssion(internal-error) printing subprogram argument Message-ID: <20180103043345.n6blge377ybsdx6q@adacore.com> References: <20171213103655.msbaxfrykc36f4a7@adacore.com> <20171215094755.dwocipbcwvtdm6f6@adacore.com> <00320239-44c8-b9c3-013b-b27c771e3401@redhat.com> <07a154ef-b6f5-ad86-1410-a73620de4b5b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07a154ef-b6f5-ad86-1410-a73620de4b5b@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-01/txt/msg00024.txt.bz2 Hi Pedro, > > Maybe what we need is to be a little less aggressive then and > > add a new symbol_name_match_type::SEARCH_SYMBOL instead that takes as > > input a non-user-input search symbol like symbol_name_match_type::LITERAL > > was, and then we skip any decoding/demangling steps (like LITERAL) and make: > > - Ada treat that as a verbatim match, > > - other languages treat it as symbol_name_match_type::FULL. [...] > With the patch below applied on top, which is a minimal version of > the design change I suggested (LITERAL -> SEARCH_SYMBOL), I now get > again the same "maint check-psymtabs" output that I get with system gdb. > So seems like this is on the good track. > > Your internal-error test still passes as well as the new > "maint check-psymtabs" for gdb.ada/ testcase. Sounds like we are indeed on the right track! I ran the changes through both the official testsuite and AdaCore's testsuite, and I can confirm no regression :). Is there something else I can do to help? -- Joel