From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114453 invoked by alias); 3 Jan 2018 03:23:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114437 invoked by uid 89); 3 Jan 2018 03:23:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=so! X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jan 2018 03:23:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 785281174DD; Tue, 2 Jan 2018 22:23:50 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id JANnGWUPmJRv; Tue, 2 Jan 2018 22:23:50 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 148AE1174D7; Tue, 2 Jan 2018 22:23:50 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id F065D809B6; Wed, 3 Jan 2018 07:23:45 +0400 (+04) Date: Wed, 03 Jan 2018 03:23:00 -0000 From: Joel Brobecker To: Xavier Roirand Cc: gdb-patches@sourceware.org Subject: Re: [RFA/v5] (Ada) New command to stop at start of exception handler. Message-ID: <20180103032345.evvfmbcaubfy43uw@adacore.com> References: <1514908089-29151-1-git-send-email-roirand@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1514908089-29151-1-git-send-email-roirand@adacore.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-01/txt/msg00022.txt.bz2 Hi Xavier, > gdb/ChangeLog: > > * ada-lang.h (ada_exception_catchpoint_kind) : > Add field. > * ada-lang.c (struct exception_support_info) : > Add field. > (default_exception_support_info) : Add field. > (exception_support_info_fallback) : Add field. > (ada_exception_name_addr_1): Add "catch handlers" handling. > (ada_exception_catchpoint_cond_string) : New parameter. > Update all callers. > (create_excep_cond_exprs) : Add parameter. > (re_set_exception): Update create_excep_cond_exprs call. > (print_it_exception, print_one_exception, print_mention_exception) > (print_recreate_exception): Add "catch handler" handling. > (allocate_location_catch_handlers, re_set_catch_handlers) > (check_status_catch_handlers, print_it_catch_handlers) > (print_one_catch_handlers, print_mention_catch_handlers) > (print_recreate_catch_handlers): New function. > (catch_handlers_breakpoint_ops): New variable. > (catch_ada_exception_command_split) : > Add parameter. Add "catch handler" handling. > (ada_exception_sym_name, ada_exception_breakpoint_ops): > Add "catch handler" handling. > (ada_exception_catchpoint_cond_string): Add "catch handler" > handling. > (create_ada_exception_catchpoint): Update create_excep_cond_exprs > call. > (catch_ada_handlers_command): New function. > (initialize_ada_catchpoint_ops): Initialize "catch handlers" > operations structure. > (_initialize_ada_language): Add "catch handlers" command entry. > * NEWS: Document "catch handlers" feature. > > gdb/doc/ChangeLog: > > * gdb.texinfo (Set Catchpoints): Add documentation for new > "catch handlers" action. > > gdb/testsuite/ChangeLog: > > gdb.ada/excep_handle.exp: New testcase. > gdb.ada/excep_handle/foo.adb: New file. > gdb.ada/excep_handle/pck.ads: New file. > > Tested on x86_64-linux. Looks good. You can go ahead and push. Just remember to actually add the 3 ChangeLog entries before doing so! ;-) -- Joel