From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16169 invoked by alias); 20 Dec 2017 10:40:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16096 invoked by uid 89); 20 Dec 2017 10:40:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pg0-f42.google.com Received: from mail-pg0-f42.google.com (HELO mail-pg0-f42.google.com) (74.125.83.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Dec 2017 10:40:15 +0000 Received: by mail-pg0-f42.google.com with SMTP id j4so11778287pgp.1 for ; Wed, 20 Dec 2017 02:40:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KO7Tt+oWJhetvxCXMOq8MWe9Qbk4knCEBHvfjVeLB5c=; b=Q6zTvPgPVm7mVNWfmUCf7fOul1F/HmAgEn7x7MPfyToDpYIQ4/MLrwg4ZZcaOCsyoQ beXkfn+pHYu1DIH/T8CSiFDVlfsJKAPGAITjyiS+c/RtCR70zRBgWF6WGcDXGNtYYfIl sPX5GwO5fZa8v8ACUWT2abaC80XgxC6MRm+51z5tLTtUyL6PyIV8mxO+kPK3S6TIxaEE +QCmwHSR6F2Lkgc4f1s4oKmKce1FOtRLHDKlXpVRblvzX7jBAx5abYJRQCCWjqYh58Jk L53dRY8RC1zErFAJCRF36iTSHmyMCuAqWWeVRoZ8is7fUcXchdX8XwX6XVteKB20zWJo FX4w== X-Gm-Message-State: AKGB3mKhbYdi2a590AI/HtRGJiB1omUcgqTdqIS6ty5PpQtgZIOKfjHT mPKATiBvHhlKdl4d421z+6nzZAzf X-Google-Smtp-Source: ACJfBosrjSRhCOn2Aho9CUg5NocsFgBh6U6m8ArKYPsUD03IASIXFWVCIAa1QdI1cMrNA644tROMKg== X-Received: by 10.101.100.17 with SMTP id a17mr5879778pgv.452.1513766413685; Wed, 20 Dec 2017 02:40:13 -0800 (PST) Received: from localhost (g128.222-224-187.ppp.wakwak.ne.jp. [222.224.187.128]) by smtp.gmail.com with ESMTPSA id e190sm32311280pfe.15.2017.12.20.02.40.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Dec 2017 02:40:13 -0800 (PST) Date: Wed, 20 Dec 2017 10:40:00 -0000 From: Stafford Horne To: Eli Zaretskii Cc: gdb-patches@sourceware.org, openrisc@lists.librecores.org Subject: Re: [PATCH v3 1/4] reggroups: Add test and docs for `info reg $reggroup` feature Message-ID: <20171220104010.GC32243@lianli.shorne-pla.net> References: <20171219142257.13402-1-shorne@gmail.com> <20171219142257.13402-2-shorne@gmail.com> <837etiptz2.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <837etiptz2.fsf@gnu.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00443.txt.bz2 On Tue, Dec 19, 2017 at 06:23:29PM +0200, Eli Zaretskii wrote: > > From: Stafford Horne > > Cc: Openrisc , Stafford Horne > > Date: Tue, 19 Dec 2017 23:22:54 +0900 > > > > Until now this feature has existed but was not documented. Adding docs > > and tests. > > Thanks! > > > +@item info registers @var{reggroup} @dots{} > > +Print the name and value of the registers in each of the specified > > +@var{reggroup}. The @var{reggoup} can be any of those returned by > > Please use "@var{reggroup}s", with the trailing "s", otherwise this is > not correct English. OK. > > +@code{maint print reggroups}. OK. > Please add here a cross-reference to the node where "maint print > reggroups" is described. > > > c = add_info ("registers", info_registers_command, _("\ > > List of integer registers and their contents, for selected stack frame.\n\ > > -Register name as argument means describe only that register.")); > > +Register name as argument means describe only that register.\n\ > > +Register group name as argument means describe the registers in the\n\ > > +named register group.")); > > Since this command accepts more than one reggroup, I think the doc > string should mention that. OK. > The documentation parts are okay with these nits fixed. Thank you. -Stafford