From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39675 invoked by alias); 14 Dec 2017 05:42:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39661 invoked by uid 89); 14 Dec 2017 05:42:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f171.google.com Received: from mail-pf0-f171.google.com (HELO mail-pf0-f171.google.com) (209.85.192.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Dec 2017 05:42:48 +0000 Received: by mail-pf0-f171.google.com with SMTP id j28so2914475pfk.8 for ; Wed, 13 Dec 2017 21:42:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rarRkTYuwT9IdBLNiOr/dLBTAay2rG41+8G+TmYFGuw=; b=rTgLaXYDi0m+C3ozhUBpSMBqPA6Utfa7FQ7c77gbYgvU7V3WD4y16G67TXvS3To6PC 5l9Om2YPTXpKHzTMIgrdO/VbtzhnLAsYyEYxCVP3npueKgziSGuI5psU/TOMuN3QQs9R PizAXVjapDPXkKIaN9LOStpb5YQe0t+UNtyOd7sa0hQK7f9Iw++XLh3ebzITLKlEdIjB uuIy2IkAi2Wrgp4OxC6GA8ix2whToVLoy03sYwE02wCd/011Use4uivyezpfvu5q0aIJ fvhpwP3O3HApkIJFT2fO5SD72PSpBdoadhXGDLRMbOwlOv39UckHiIW7RcyAiJya4REh BVbg== X-Gm-Message-State: AKGB3mKTrDXIeJE8Khyb5glp0LAYns+vsnyjgJxbROAL0WTonkMV89J1 jk65u/OaDRzyZtUIzcDhOD0LTNq/ X-Google-Smtp-Source: ACJfBoulfxQylH5wftOS9p5nVfQypoFMOoQmsaeWjXdkioWtIy+hfBtwyKQkXFRDJgjVYU9csIn+fQ== X-Received: by 10.159.211.71 with SMTP id g7mr8142497plp.15.1513230167074; Wed, 13 Dec 2017 21:42:47 -0800 (PST) Received: from localhost (g41.219-103-184.ppp.wakwak.ne.jp. [219.103.184.41]) by smtp.gmail.com with ESMTPSA id y79sm5798141pfb.113.2017.12.13.21.42.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Dec 2017 21:42:46 -0800 (PST) Date: Thu, 14 Dec 2017 05:42:00 -0000 From: Stafford Horne To: Joel Brobecker Cc: GDB patches Subject: Re: [PATCH] gdb: Fix ARI warnings in or1k-tdep.c Message-ID: <20171214054244.GA32243@lianli.shorne-pla.net> References: <20171213132654.19739-1-shorne@gmail.com> <20171214025106.o4kyh2vkql7ehwpx@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171214025106.o4kyh2vkql7ehwpx@adacore.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00336.txt.bz2 On Thu, Dec 14, 2017 at 06:51:06AM +0400, Joel Brobecker wrote: > Hello, > > A very minor thing: > > > diff --git a/gdb/or1k-tdep.c b/gdb/or1k-tdep.c > > index 54b365e958..06ee53e83c 100644 > > --- a/gdb/or1k-tdep.c > > +++ b/gdb/or1k-tdep.c > > @@ -132,7 +132,7 @@ or1k_analyse_inst (uint32_t inst, const char *format, ...) > > > > /* Check we got something, and if so skip on. */ > > if (start_ptr == end_ptr) > > - error ("bitstring \"%s\" at offset %d has no length field.\n", > > + error (_("bitstring \"%s\" at offset %d has no length field."), > > format, i); > > The second line in the error looks over indented to me. I think > it ought to be aligned with the other arguments on the first line: > > error (_("bitstring \"%s\" at offset %d has no length field."), > format, i); > > (I think I saw about 3 instances of the same alignment issue) Understood, I didnt notice those. Will fix, I have a few other patches to send. -Stafford